Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMove data frame fields names to snake_case. #327
+18
−18
Conversation
ruebot
requested review from
lintool and
ianmilligan1
Jul 17, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Jul 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
=======================================
Coverage 74.97% 74.97%
=======================================
Files 39 39
Lines 1123 1123
Branches 197 197
=======================================
Hits 842 842
Misses 215 215
Partials 66 66
Continue to review full report at Codecov.
|
ianmilligan1
approved these changes
Jul 18, 2019
Tested all scripts locally with my own sample data and all worked perfectly – great stuff, @ruebot. If you want to change the field names to be more descriptive, happy to re-review too, but otherwise happy to merge. Just let me know. |
This comment has been minimized.
This comment has been minimized.
eh, let's just leave it as is now. |
ianmilligan1
merged commit f35d54e
into
master
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedJul 17, 2019
GitHub issue(s): #229
What does this Pull Request do?
Move data frame fields names to snake_case.
How should this be tested?
rm -rf ~/.m2/repository/* && mvn clean install
rm -rf ~/.ivy2/* && ~/bin/spark-2.4.3-bin-hadoop2.7/bin/spark-shell --packages io.archivesunleashed:aut:0.17.1-SNAPSHOT
List of Domains
Hyperlink Network
Image Analysis
Additional Notes:
@ianmilligan1 @lintool should we go a bit further on some of these field names? For example, should we change
src
tosource
, ordest_domain
todestination_domain
? If so, I'm happy to update this PR.Also, we need update the documentation on the archivesunleashed.org/aut for the next release. The above example should do it, since that's were they came from.