Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SU-DGES Style #4201

Open
wants to merge 3 commits into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@OGMalan @csl-bot @adam3smith
@OGMalan
Copy link

commented Jul 16, 2019

Creating a csl style based on the Stellenbosch University Department of Geography and Environmental Studies referencing guidelines.
@OGMalan
Create stellenbosch-university-department-of-geography-and-environmen… 
…tal-studies-harvard.csl

Creating a csl style based on the Stellenbosch University Department of Geography and Environmental Studies referencing guidelines.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
147f9a9
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 16, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 16, 2019

😟 There are some issues with your submission.

2 tests failed

stellenbosch-university-department-of-geography-and-environmental-studies-harvard: "self" link must match the style ID

expected: "stellenbosch-university-department-of-geography-and-environmental-studies-harvard"
     got: "http://www.zotero.org/styles/stellenbosch-university-department-of-geography-and-environmental-studies-harvard"

(compared using ==)

stellenbosch-university-department-of-geography-and-environmental-studies-harvard: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min () and et-al-use-first (1) to be of same type

Please check the test report for details.
@OGMalan
Update stellenbosch-university-department-of-geography-and-environmen… 
…tal-studies-harvard.csl

Fixed id and attempted to fix et al type issue.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
37bf563
@OGMalan

OGMalan reviewed Jul 16, 2019
View changes

Copy link
Author

left a comment

Fixed id and url and attempted to fix et al issues.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 16, 2019

😟 There are some issues with your submission.

3 tests failed

stellenbosch-university-department-of-geography-and-environmental-studies-harvard: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/stellenbosch-university-department-of-geography-and-environmental-studies-harvard"
     got: "stellenbosch-university-department-of-geography-and-environmental-studies-harvard"

(compared using ==)

stellenbosch-university-department-of-geography-and-environmental-studies-harvard: "self" link must match the style ID

expected: "http://www.zotero.org/styles/stellenbosch-university-department-of-geography-and-environmental-studies-harvard"
     got: "stellenbosch-university-department-of-geography-and-environmental-studies-harvard"

(compared using ==)

stellenbosch-university-department-of-geography-and-environmental-studies-harvard: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min () and et-al-use-first (1) to be of same type

Please check the test report for details.
@OGMalan
Update stellenbosch-university-department-of-geography-and-environmen… 
…tal-studies-harvard.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
81c3c68
@OGMalan

OGMalan reviewed Jul 16, 2019
View changes

Copy link
Author

left a comment

Fixed id and link.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 16, 2019

😟 There are some issues with your submission.

1 test failed

stellenbosch-university-department-of-geography-and-environmental-studies-harvard: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min () and et-al-use-first (1) to be of same type

Please check the test report for details.
@OGMalan

This comment has been minimized.

Sign in to view
Copy link
Author

commented Jul 16, 2019

I would greatly appreciate any help in fixing the remaining type issue with the "stellenbosch-university-department-of-geography-and-environmental-studies-harvard: name nodes must have valid et-al-min and et-al-use-first attributes" error, as I do not understand why I am getting it.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jul 16, 2019

Is et al ever used in the bibliography?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.