Skip to content

/claw-playbook

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 18.04 #125

Open
wants to merge 2 commits into
base: dev
from
+13 −22

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ruebot @Natkeeran @dannylamb
@ruebot
Copy link

commented Jul 12, 2019

GitHub Issue: Islandora-CLAW/CLAW#848

What does this Pull Request do?

How should this be tested?

Interested parties

@Islandora-Devops/committers
@ruebot
Update to 18.04 
- Update Vagrantfile to use 18.04 for Ubuntu builds
- Tweak package names, and required packages for 18.04
- Updates to get rid of some deprecation warnings
- Addresses Islandora-CLAW/CLAW#848
- Requires Islandora-Devops/ansible-role-grok#6
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
57a5e30

@ruebot ruebot referenced this pull request Jul 12, 2019

Open

Claw-playbook: Update to fully support Ubuntu 18.04 'Bionic Beaver' #848

@Natkeeran

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jul 15, 2019 •
edited

Deployed without issues. Sanity tests with image works.

@ruebot Do we only need this for ubuntu/xenial64?

README may need to be updated. Can be a separate issue.
@dannylamb

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jul 15, 2019

vagrant up
@dannylamb

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jul 15, 2019

failed on installing grok. did any underlying roles change?
@Natkeeran

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jul 15, 2019

@dannylamb

Did you get the Islandora-Devops/ansible-role-grok#6 ?
@dannylamb

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jul 15, 2019

Bingo. Read the PR description Danny....
@dannylamb

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jul 15, 2019

Ok, let's try this again 🤦‍♂
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Author

commented Jul 15, 2019

@Natkeeran I'll update on Friday, when I'm back at York.
@dannylamb

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jul 16, 2019

With Islandora-Devops/ansible-role-grok#6 I'm getting

TASK [Islandora-Devops.grok : Install Grok dependencies (apt)] *****************
Monday 15 July 2019  16:51:50 -0300 (0:00:02.767)       0:35:07.447 *********** 
failed: [default] (item=[u'cmake', u'libpng16-dev', u'libtiff-dev', u'liblcms2-dev']) => {"ansible_loop_var": "item", "changed": false, "item": ["cmake", "libpng16-dev", "libtiff-dev", "liblcms2-dev"], "msg": "No package matching 'libpng16-dev' is available"}
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Author

commented Jul 19, 2019

Not sure on the proper procedure for testing Ansible Playbooks with internal/external roles, but what I did locally was to edit roles/external/Islandora-Devops.grok/tasks/install.yml with the changes in Islandora-Devops/ansible-role-grok#6, then do vagrant up.
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Author

commented Jul 19, 2019

Updated locally, and testing with the changes @Natkeeran requested #125 (comment)
@ruebot
Update README and remove some cruft per @Natkeeran's review.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
16f2e43
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Author

commented Jul 19, 2019

Tested with 16f2e43, and things appear to be good.
@dannylamb

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jul 19, 2019

FWIW I deleted the role and then updated requirements.yml to point to the branch for the PR. Let me try again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.