Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SU-DGES Style #4201

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@OGMalan
Copy link

commented Jul 16, 2019

Creating a csl style based on the Stellenbosch University Department of Geography and Environmental Studies referencing guidelines.

Create stellenbosch-university-department-of-geography-and-environmen…
…tal-studies-harvard.csl

Creating a csl style based on the Stellenbosch University Department of Geography and Environmental Studies referencing guidelines.
@csl-bot

This comment has been minimized.

Copy link

commented Jul 16, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 16, 2019

😟 There are some issues with your submission.

2 tests failed

stellenbosch-university-department-of-geography-and-environmental-studies-harvard: "self" link must match the style ID

expected: "stellenbosch-university-department-of-geography-and-environmental-studies-harvard"
     got: "http://www.zotero.org/styles/stellenbosch-university-department-of-geography-and-environmental-studies-harvard"

(compared using ==)

stellenbosch-university-department-of-geography-and-environmental-studies-harvard: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min () and et-al-use-first (1) to be of same type

Please check the test report for details.

Update stellenbosch-university-department-of-geography-and-environmen…
…tal-studies-harvard.csl

Fixed id and attempted to fix et al type issue.
@OGMalan
Copy link
Author

left a comment

Fixed id and url and attempted to fix et al issues.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 16, 2019

😟 There are some issues with your submission.

3 tests failed

stellenbosch-university-department-of-geography-and-environmental-studies-harvard: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/stellenbosch-university-department-of-geography-and-environmental-studies-harvard"
     got: "stellenbosch-university-department-of-geography-and-environmental-studies-harvard"

(compared using ==)

stellenbosch-university-department-of-geography-and-environmental-studies-harvard: "self" link must match the style ID

expected: "http://www.zotero.org/styles/stellenbosch-university-department-of-geography-and-environmental-studies-harvard"
     got: "stellenbosch-university-department-of-geography-and-environmental-studies-harvard"

(compared using ==)

stellenbosch-university-department-of-geography-and-environmental-studies-harvard: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min () and et-al-use-first (1) to be of same type

Please check the test report for details.

@OGMalan
Copy link
Author

left a comment

Fixed id and link.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 16, 2019

😟 There are some issues with your submission.

1 test failed

stellenbosch-university-department-of-geography-and-environmental-studies-harvard: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min () and et-al-use-first (1) to be of same type

Please check the test report for details.

@OGMalan

This comment has been minimized.

Copy link
Author

commented Jul 16, 2019

I would greatly appreciate any help in fixing the remaining type issue with the "stellenbosch-university-department-of-geography-and-environmental-studies-harvard: name nodes must have valid et-al-min and et-al-use-first attributes" error, as I do not understand why I am getting it.

@adam3smith

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

Is et al ever used in the bibliography?

@OGMalan

This comment has been minimized.

Copy link
Author

commented Jul 24, 2019

Is et al ever used in the bibliography?

As far as I can tell, yes, but I am not sure. The style works as intended when I manually install it with Mendeley, or use it with Zotero and I really do not understand at all why I am getting that error.

Thank you for your help.

@adam3smith

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

Sorry, you're misunderstanding my question: according to the style guide, should et al. be used in the bibliography? If so, when exactly?
The problem is that you currently that you have et-al-use-first without et-al-min but more important than fixing the automated test (which I can do for you) is to fix it correctly.

@OGMalan

This comment has been minimized.

Copy link
Author

commented Jul 25, 2019

Sorry, you're misunderstanding my question: according to the style guide, should et al. be used in the bibliography? If so, when exactly?
The problem is that you currently that you have et-al-use-first without et-al-min but more important than fixing the automated test (which I can do for you) is to fix it correctly.

Oh sorry for misunderstanding! No, et al is used in-text when a work has more than 3 authors. Check the last bullet of page 20 in the research report guidelines (the documentation link).

@csl-bot

This comment has been minimized.

Copy link

commented Jul 25, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

stellenbosch-university-department-of-geography-and-environmental-studies-harvard.csl (new)
(CSL search by example 2012; Hancké, Rhodes & Thatcher 2007)
(Fenner et al. 2019; Mares 2001)

Fenner M, Crosas M, Grethe JS, Kennedy D, Hermjakob H, Rocca-Serra P, Durand G, Berjon R, Karcher S, Martone M & Clark T 2019. A data citation roadmap for scholarly data repositories. Scientific Data 6, 1: 28. [online]. Available from: http://www.nature.com/articles/s41597-019-0031-8 [Accessed 27 April 2019].
Mares I 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? In Hall PA & Soskice D (eds) Varieties of capitalism. The institutional foundations of comparative advantage, 184–213. New York: Oxford University Press.
CSL search by example 2012. [online]. Available from: http://editor.citationstyles.org/searchByExample/ [Accessed 15 December 2012].
Hancké B, Rhodes M & Thatcher M (eds) 2007. Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
@adam3smith

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

@rmzelle style is good to go. If you could check metadata & merge, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.