Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upReorganize Chicago Figures code #2220
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Sep 12, 2016
|
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.
If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Sep 12, 2016
|
|
This comment has been minimized.
This comment has been minimized.
|
Not fully tested, since the current stable version of Zotero has a citation bug that affects this particular style. Should be fixed in the next release (https://forums.zotero.org/discussion/62288/citeproc-js-bug), at which point I'll revisit this and merge. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Oct 8, 2016
|
|
rmzelle
merged commit 1910733
into
master
Oct 8, 2016
rmzelle
deleted the
chicago-figures
branch
Oct 8, 2016
This comment has been minimized.
This comment has been minimized.
|
Looks good in Zotero 4.0.29.15. |
rmzelle commentedSep 12, 2016
Reorganize code a little in response to #2196.
Better use of cs:choose, groups, and the style will now print at least something for most item types.