Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed errors of Annals of Botany #2375

Merged
merged 8 commits into from Dec 26, 2016

Conversation

@csl-bot

This comment has been minimized.

Copy link

commented Dec 24, 2016

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

commented Dec 24, 2016

😃 Your submission passed all our automated tests.

@POBrien333 POBrien333 changed the title fixed error with book chapters fixed errors of Annals of Botany Dec 24, 2016

@csl-bot

This comment has been minimized.

Copy link

commented Dec 24, 2016

😟 There are some issues with your submission. Please check the test report for details.

</group>
<text variable="url" suffix=". "/>
<date variabiable="accessed"/>
</else-if>

This comment has been minimized.

Copy link
@rmzelle

rmzelle Dec 25, 2016

Member

@damnation333, see the validation results: http://validator.citationstyles.org/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fdamnation333%2Fstyles%2Fpatch-8%2Fannals-of-botany.csl&version=1.0.1

To use italics, use font-style="italic". To print the URL, use the "URL" (all-caps) variable. And change "variabiable" to "variable".

@csl-bot

This comment has been minimized.

Copy link

commented Dec 25, 2016

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Dec 25, 2016

😃 Your submission passed all our automated tests.

<else-if type="webpage" match="any">
<group suffix=". ">
<text macro="title" font-style="italic" prefix=" "/>
</group>

This comment has been minimized.

Copy link
@rmzelle

rmzelle Dec 26, 2016

Member

@damnation333, while it's good to put as much separating punctuation in groups as possible, groups with only a single child element only complicate things, and should be avoided. (moving the suffix from the group to the text element would allow you to delete lines 108 and 110)

<label form="short" prefix=" "/>
<names variable="editor translator" delimiter="," suffix=" ">
<name name-as-sort-order="all" sort-separator=" " initialize-with="" delimiter=", " delimiter-precedes-last="always"/>
<label form="short" prefix=", " suffix=""/>

This comment has been minimized.

Copy link
@rmzelle

rmzelle Dec 26, 2016

Member

@damnation333, it's also cleaner to delete empty prefixes and suffixes, like suffix="" here.

<else-if type="chapter paper-conference" match="any">
<text macro="title" prefix=" "/>
<group prefix=".">
<group prefix=" In: ">

This comment has been minimized.

Copy link
@rmzelle

rmzelle Dec 26, 2016

Member

@damnation333, if possible, we'd like to use CSL terms instead of verbatim text, because terms can be automatically translated, and using them make CSL styles easier to (re)use in other languages. Here, you can change <group prefix=" In: "> to e.g.

<group prefix=" " >
  <text term="in" text-case="capitalize-first" suffix=": "/>

(Don't take my nitpicking the wrong way, by the way. We appreciate your help. I'm just pointing out some things that can be improved)

This comment has been minimized.

Copy link
@POBrien333

POBrien333 Dec 26, 2016

Author Contributor

this is really helpful. Thanks for the little tips here. Exactly what I need to get better at this. Love it. Like solving puzzles.

@csl-bot

This comment has been minimized.

Copy link

commented Dec 26, 2016

😃 Your submission passed all our automated tests.

<date-part name="day" form="numeric" suffix=" "/>
<date-part name="month" form="short" suffix=" "/>
<date-part name="year" form="long"/>
</date>

This comment has been minimized.

Copy link
@rmzelle

rmzelle Dec 26, 2016

Member

@damnation333, is this correct now? I don't see any spaces between the URL and the date (there is just a "." suffix on the URL variable), which probably isn't what you want.

This comment has been minimized.

Copy link
@rmzelle

rmzelle Dec 26, 2016

Member

(if you need ". " as a delimiter between the title and URL, and between the URL and "accessed" date, it would be much better to delete these suffixes and add a parent group with delimiter=". ")

@csl-bot

This comment has been minimized.

Copy link

commented Dec 26, 2016

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

commented on annals-of-botany.csl in eb5d789 Dec 26, 2016

@damnation333, this still doesn't look quite correct. The prefix on the URL variable should now be redundant.

(it would also be neater to move the prefix on the "title" variable up to the group)

@csl-bot

This comment has been minimized.

Copy link

commented Dec 26, 2016

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Dec 26, 2016

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit f2676d9 into citation-style-language:master Dec 26, 2016

@rmzelle

This comment has been minimized.

Copy link
Member

commented Dec 26, 2016

Thanks! (accepted after reindenting the style with http://formatter.citationstyles.org/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.