Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "Harvard"/"Oxford"/"Vancouver" #2514

Merged
merged 2 commits into from Mar 12, 2017

Conversation

@rmzelle
Copy link
Member

commented Feb 19, 2017

Follow-up of #2512.

@csl-bot

This comment has been minimized.

Copy link

commented Feb 19, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

commented Feb 19, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member Author

commented Feb 19, 2017

@adam3smith, for you to merge. Just doing the titles for now should make it easy to roll things back, and minimize disruption for programs that don't use renamed-styles.json, or documentation that linked directly to styles.

@rmzelle

This comment has been minimized.

Copy link
Member Author

commented Feb 19, 2017

There is a drawback of this, by the way, in that the focus of people who are specifically looking for a "Harvard" style will be drawn more to the remaining three styles that will start with "Harvard":

Harvard Educational Review
Harvard Reference format 1 (author-date)
Harvard Reference format 7 (author-date, German)

I still think we should make the change, but it increases the importance of getting rid of the "format 1" (http://xbiblio-devel.2463403.n2.nabble.com/Proposal-Retire-duplicate-quot-Harvard-quot-styles-harvard1-csl-amp-harvard7de-csl-td7579422.html) and "format 7" (#74 and previous link) titles.

@rmzelle

This comment has been minimized.

Copy link
Member Author

commented Feb 19, 2017

it increases the importance of getting rid of the "format 1" (...) and "format 7" (...) titles.

@adam3smith, in the xbiblio-devel discussion it seemed like the consensus was to turn the "format 1" style into a dependent, as a prelude to its eventual removal, but that hasn't happened yet. I think that would be a good change, but we might also want to change the title to indicate its deprecated status, e.g. to "(retired) Harvard Reference format 1 (replaced by "Cite Them Right 9th edition - Harvard")". Maybe we should then give Mendeley 6 months or so to prepare on their end, and then remove it altogether after that point (and add it to renamed-styles.json).

Do you know if Mendeley nowadays comes with the Cite Them Right style in fresh installations? I have it in my copy of Mendeley, but I don't remember if I installed it myself at some point.

@bwiernik

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2017

Do you know if Mendeley nowadays comes with the Cite Them Right style in fresh installations? I have it in my copy of Mendeley, but I don't remember if I installed it myself at some point.

Yes, the default styles are:
AMA
APSA
APA
ASA
Chicago 16 (note, full note, author-date)
Harvard - Cite them Right 9
Harvard Reference format 1
IEEE
MHRA
MLA
NLM
Nature
Vancouver

@adam3smith adam3smith merged commit 5def1b5 into master Mar 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

commented Mar 12, 2017

Cool, thanks. As per one of the threads, I prepared a branch with Harvard1 turned into a dependent. There are currently 25 styles linking to it as a template. @rmzelle -- remind me what we do for those cases?

I also agree that we should be getting rid of it, but making it dependent on a decent style seems like a good idea anyway (and we'll need to resolve the template question either way).

@rmzelle

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2017

There are currently 25 styles linking to it as a template. @rmzelle -- remind me what we do for those cases?

We don't really have to enforce the current requirement that all "template" links point to existing styles, but it helps catch typos, and usually doesn't give problems. In almost all cases, I just change the "template" link to the same style you redirect the old style ID to in renamed-styles.json. Just don't think of it as purely an pointer to the originating style. It can also be a close relative that is of higher or equally high quality as the style containing the "template" link.

@rmzelle rmzelle deleted the move-harvard branch Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.