Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update biomed-central.csl #2569

Merged
merged 3 commits into from Mar 18, 2017

Conversation

@POBrien333
Copy link
Contributor

commented Mar 15, 2017

Fix error with chapter as mentioned here: https://forums.zotero.org/discussion/64762/style-error-biomed-central
Please hold for merge in case user requests some other changes.

Update biomed-central.csl
Fix error with chapter as mentioned here: https://forums.zotero.org/discussion/64762/style-error-biomed-central#latest
Please hold for merge in case user requests some other changes.
@csl-bot

This comment has been minimized.

Copy link

commented Mar 15, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

commented Mar 15, 2017

😃 Your submission passed all our automated tests.

Put comment back in
(we need to fix that in the editor)
@adam3smith

This comment has been minimized.

Copy link
Member

commented Mar 17, 2017

I need to test this, but I think

<group delimiter=": ">
  <text term="in" text-case="capitalize-first"/>
  <group delimiter=". ">                 
    <text macro="editor"/>
    <text macro="container-title"/>
  </group>
</group>

will work better, i.e. including for chapters that don't have editors, which we see occasionally in the biosciences.

@csl-bot

This comment has been minimized.

Copy link

commented Mar 17, 2017

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Mar 18, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit efccabc into citation-style-language:master Mar 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

commented Mar 18, 2017

Looks good. Thanks both. (no need to wait, it's been two days since @damnation333 asked for more detail and we can always create another PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.