Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate biomed-central.csl #2569
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 15, 2017
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 15, 2017
|
This comment has been minimized.
This comment has been minimized.
I need to test this, but I think <group delimiter=": ">
<text term="in" text-case="capitalize-first"/>
<group delimiter=". ">
<text macro="editor"/>
<text macro="container-title"/>
</group>
</group> will work better, i.e. including for chapters that don't have editors, which we see occasionally in the biosciences. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 17, 2017
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 18, 2017
|
rmzelle
merged commit efccabc
into
citation-style-language:master
Mar 18, 2017
1 check passed
This comment has been minimized.
This comment has been minimized.
Looks good. Thanks both. (no need to wait, it's been two days since @damnation333 asked for more detail and we can always create another PR) |
POBrien333 commentedMar 15, 2017
•
edited by rmzelle
Fix error with chapter as mentioned here: https://forums.zotero.org/discussion/64762/style-error-biomed-central
Please hold for merge in case user requests some other changes.