Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd test for "sentence" case on title and container-title #2613
Conversation
rmzelle
added some commits
Apr 1, 2017
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 1, 2017
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 1, 2017
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 1, 2017
|
rmzelle
reviewed
Apr 1, 2017
end | ||
end | ||
end | ||
|
This comment has been minimized.
This comment has been minimized.
rmzelle
Apr 1, 2017
Author
Member
@adam3smith, the logic is not the most elegant, but RSpec is still mostly a mystery to me. It seems to work and doesn't seem to be particularly slow, so I guess it's okay.
This comment has been minimized.
This comment has been minimized.
@adam3smith, I'll leave this for you to merge. Looks like your earlier find-and-replace didn't catch all the cases. |
adam3smith
merged commit 800c787
into
master
Apr 2, 2017
This comment has been minimized.
This comment has been minimized.
Looks good to me. Thanks -- yes, I used an overly simplistic |
rmzelle commentedApr 1, 2017
(follow-up of #2609)