Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate applied-spectroscopy-reviews.csl #2652
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 26, 2017
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 26, 2017
|
This comment has been minimized.
This comment has been minimized.
Continuation of #2649 (comment) |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 30, 2017
|
This comment has been minimized.
This comment has been minimized.
@gul916 @damnation333 made some tweaks for robustness & elegance. If either of you could take this for a spin before I merge? |
This comment has been minimized.
This comment has been minimized.
Hi @adam3smith , Minor corrections: |
This comment has been minimized.
This comment has been minimized.
OK, the two spaces are fixed. Are you sure about omitting the day? It's such an odd requirement if you're going to include access dates and I wouldn't take specifics in the often hastily written instructions for authors too literally. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 30, 2017
|
This comment has been minimized.
This comment has been minimized.
@adam3smith |
adam3smith
merged commit 111f980
into
citation-style-language:master
Apr 30, 2017
1 check passed
This comment has been minimized.
This comment has been minimized.
Thanks! |
gul916 commentedApr 26, 2017
enhance report and proceeding parts, based on damnation333 file