Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate comparative-politics.csl #2840
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 25, 2017
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
POBrien333
changed the title
Create comparative-politics.csl
Create comparative-politics.csl (help with ibid needed)
Jul 25, 2017
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 25, 2017
|
This comment has been minimized.
This comment has been minimized.
What specifically do you need help with? The Chicago styles are good examples of how you would usually test for "position" (since cites can have more than one value for "position", you generally test from most specific, i.e. "ibid-with-locator", to least specific, i.e. "subsequent"). See http://docs.citationstyles.org/en/stable/specification.html#choose and e.g. styles/chicago-fullnote-bibliography.csl Line 1249 in 9e5c5b0 |
This comment has been minimized.
This comment has been minimized.
Thanks, @rmzelle |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 26, 2017
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 26, 2017
|
This comment has been minimized.
This comment has been minimized.
you have this as a numeric in-text style. It should be a "note" style like the Chicago note and full note styles, which will also take care of the numbering issue. |
This comment has been minimized.
This comment has been minimized.
dang. I was wondering about that. :(( |
POBrien333
changed the title
Create comparative-politics.csl (help with ibid needed)
Create comparative-politics.csl (work in progress)
Jul 26, 2017
POBrien333
changed the title
Create comparative-politics.csl (work in progress)
Create comparative-politics.csl
Jul 27, 2017
This comment has been minimized.
This comment has been minimized.
@adam3smith |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 27, 2017
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 27, 2017
|
This comment has been minimized.
This comment has been minimized.
@adam3smith, metadata looks good to me. Can you merge after reviewing the code? |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 28, 2017
|
adam3smith
reviewed
Jul 30, 2017
A couple of small nits left. @rmzelle please go ahead and merge once these are fixed, will likely be a week until I'd get to it. |
</macro> | ||
<macro name="editor"> | ||
<names variable="editor"> | ||
<name and="text" delimiter-precedes-last="never" initialize-with="."/> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Jul 30, 2017
Member
I'm seeing Stanley Rosen and Peter Hays Gries, eds. in the instructions, i.e. without initialize-with
<text term="in" suffix=" "/> | ||
<group delimiter=", "> | ||
<text macro="editor"/> | ||
<text variable="container-title" form="short" text-case="title" font-style="italic"/> |
This comment has been minimized.
This comment has been minimized.
<text variable="container-title" form="short" text-case="title" font-style="italic"/> | ||
<text macro="edition"/> | ||
</group> | ||
<group delimiter=", " prefix=" "> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Jul 30, 2017
Member
no need for the prefix -- you have that in the publisher macro already.
<text variable="container-title" text-case="title" font-style="italic"/> | ||
<group delimiter=" "> | ||
<text variable="volume" font-weight="normal"/> | ||
<text macro="year-date" prefix="(" suffix=")"/> |
This comment has been minimized.
This comment has been minimized.
POBrien333
added some commits
Jul 30, 2017
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 30, 2017
|
1 similar comment
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 30, 2017
|
rmzelle
merged commit 3987029
into
citation-style-language:master
Jul 30, 2017
1 check passed
This comment has been minimized.
This comment has been minimized.
Thanks! |
POBrien333 commentedJul 25, 2017
via https://forums.zotero.org/discussion/55343/style-request-comparative-politics
Open article here: http://www.ingentaconnect.com/contentone/cuny/cp/2014/00000047/00000001/art00007
Can you guys help me with the ibid stuff?