Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create isabella-stewart-gardner-museum.csl #2843

Merged
merged 18 commits into from Sep 4, 2017

Conversation

@POBrien333
Copy link
Contributor

commented Jul 26, 2017

via https://forums.zotero.org/discussion/comment/281298/#Comment_281298

ISG Museum House Style.pdf
Crivelli Article entry 1_catalogue_final.pdf
Crivelli bibliography _catalogue_bib.pdf

Very similar, Metropolitan Museum, shows the bibliography section: Met Museum House Style.pdf

The one question is why does it not print the bracket ) at the end of the publisher section? e.g.: Walter Isaacson. Steve Jobs. (New York, NY: Simon & Schuster, 2011.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 26, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

commented Jul 26, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 26, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 26, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 26, 2017

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 26, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Jul 27, 2017

The one question is why does it not print the bracket ) at the end of the publisher section? e.g.: Walter Isaacson. Steve Jobs. (New York, NY: Simon & Schuster, 2011.

Are you asking why the guidelines are that way, or why the CSL style behaves that way?

@rmzelle rmzelle changed the title Create isabella-steward-gardner-museum.csl Create isabella-stewart-gardner-museum.csl Jul 27, 2017

@csl-bot

This comment has been minimized.

Copy link

commented Jul 27, 2017

😃 Your submission passed all our automated tests.

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2017

Why the style behaves like that.
Also, you did see the two other files I posted in this PR? One is a bibliographic section from the end of a book of theirs (they have notes at the end of a "chapter" and then all the references in one big section at the end).

<text macro="volume-and-collection-title"/>
<text macro="edition"/>
</group>
<group delimiter=", " prefix=" (" suffix=")">

This comment has been minimized.

Copy link
@POBrien333

POBrien333 Jul 27, 2017

Author Contributor

@rmzelle
These closing brackets here do not appear for me :(
Looks like this: Walter Isaacson. Steve Jobs. (New York, NY: Simon & Schuster, 2011.
Should be: Walter Isaacson. Steve Jobs. (New York, NY: Simon & Schuster, 2011).

This comment has been minimized.

Copy link
@rmzelle

rmzelle Jul 27, 2017

Member

Is that in Mendeley? Visual Editor?

This comment has been minimized.

Copy link
@POBrien333

POBrien333 Jul 27, 2017

Author Contributor

Visual Editor. I don't use Mendeley anymore. No use for it since I left academia ;)

This comment has been minimized.

Copy link
@rmzelle

rmzelle Jul 27, 2017

Member

I'm seeing this too in Zotero Standalone 4.0.29.17. If I remove the `display="block" it goes away. See the stripped down version at https://gist.github.com/rmzelle/e135ac9b7d6aaf6c6a2e5c99b3a55282.

Note that the specification says: "The display attribute (similar the “display” property in CSS) may be used to structure individual bibliographic entries into one or more text blocks. If used, all rendering elements should be under the control of a display attribute."

Putting display="block" on the second group fixes the issue for me: https://gist.github.com/rmzelle/f54671436636b0e5d326c175f092f641

@csl-bot

This comment has been minimized.

Copy link

commented Jul 27, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 27, 2017

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 27, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Jul 28, 2017

Also, you did see the two other files I posted in this PR?

Yes, but I only briefly looked at them. Is there anything about them that I should be aware off in reviewing this CSL style?

(also, did you receive scans of the front matter that I requested of the requestor (at https://forums.zotero.org/discussion/comment/281406#Comment_281406)? I just want to make sure we name this style correctly, and that we have the bibliographic details on hand of the style guide in case we need to track it down in the future)

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

commented Jul 28, 2017

No, didn't get anything more sent via email. Let's wait and see.

@csl-bot

This comment has been minimized.

Copy link

commented Aug 9, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Aug 9, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Aug 9, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Aug 9, 2017

@POBrien333, can you attach those additional files you received (especially the title page)? Also let me know if this should be good to merge.

@csl-bot

This comment has been minimized.

Copy link

commented Aug 10, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Aug 10, 2017

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Aug 15, 2017

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Aug 16, 2017

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Aug 16, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Aug 22, 2017

(is this in good enough shape to merge right now? You can always submit a follow-up PR)

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2017

Let me send her an email. She never replied back on the forum. I think it still has some kinks to fix though.

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2017

Closing this, as I don't want to spend more time on this than I have already.

@POBrien333 POBrien333 closed this Sep 4, 2017

@adam3smith

This comment has been minimized.

Copy link
Member

commented Sep 4, 2017

wouldn't it make sense to take it as is, though? It seems like it's pretty close.

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2017

if you want to, go ahead. :)

@rmzelle

This comment has been minimized.

Copy link
Member

commented Sep 4, 2017

I don't want to spend more time on this than I have already.

That's fine, of course. Did you tell the requestor?

@rmzelle rmzelle reopened this Sep 4, 2017

@csl-bot

This comment has been minimized.

Copy link

commented Sep 4, 2017

😃 Your submission passed all our automated tests.

1 similar comment
@csl-bot

This comment has been minimized.

Copy link

commented Sep 4, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 4e3948c into citation-style-language:master Sep 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

commented Sep 4, 2017

And thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.