Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BES journals now all use (old-DOI format) APA #3095

Merged
merged 2 commits into from Nov 11, 2017

Conversation

@adam3smith
Copy link
Member

commented Nov 5, 2017

@csl-bot

This comment has been minimized.

Copy link

commented Nov 5, 2017

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try get in touch soon (usually within a week). In the meantime, I will run some automated checks on your pull request. You should be notified of the test results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

commented Nov 5, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Nov 7, 2017

(added a link to the matching "journals" repo commit in your opening post)

How did you find out it was the case that they use APA? And are you sure the locale should be "en-US", not "en-GB"? Otherwise looks good to merge.

@adam3smith

This comment has been minimized.

Copy link
Member Author

commented Nov 7, 2017

I got an error report from Mendeley about the BES style, then started looking at them in detail. en-US vs. GB doesn't make a difference with APA styles, but I figured since they use APA, en-US made sense.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Nov 8, 2017

Okay, thanks! Just trying to make sure we have a record.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Nov 8, 2017

Could you add the dependents for "Journal of Applied Ecology" and "Methods in Ecology and Evolution"? I think you just missed them (they generate correctly from the "journals" metadata for BES).

@csl-bot

This comment has been minimized.

Copy link

commented Nov 11, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 0e02fb4 into master Nov 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rmzelle rmzelle deleted the BES branch Nov 11, 2017

@rmzelle

This comment has been minimized.

Copy link
Member

commented Nov 11, 2017

Just realized you did this in a repository branch I can commit to myself (duh), so easy to fix myself. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.