Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Elsevier dependent styles. #3339

Merged

Conversation

@cpina
Copy link
Member

commented Feb 16, 2018

Updates Elsevier styles, keeping the _skip.txt that was previously used.
I'll update the elsevier/_journals.tab if this works.
Having problems running rake locally, I'll give it one attempt to see if it works or I'll fix it properly later on if I need to debug problems.

@csl-bot

This comment has been minimized.

Copy link

commented Feb 16, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Feb 16, 2018

😟 There are some issues with your submission. Please check the test report for details.

cpina added some commits Feb 16, 2018

Deletes duplicated styles.
These styles had the same ISSN, the titles have changed since the last
Elsevier import.
@csl-bot

This comment has been minimized.

Copy link

commented Feb 16, 2018

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit 76a0a7f into citation-style-language:master Mar 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

commented Mar 9, 2018

This is great, thanks!

@adam3smith

This comment has been minimized.

Copy link
Member

commented Sep 5, 2018

@cpina could you still update _journals.tab, please?

@cpina

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2018

Yes, I can, I'll find some time next week(s)

@POBrien333

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

Hey @cpina
Just checking in if this was completed as I still have it on my log for citation style requests (https://docs.google.com/spreadsheets/d/1zc3Sl4JU7Ltu0Q55-OB0QYCJbYiguVXwpc_BzBLLZcA/edit#gid=128551622)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.