Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd AGLC4 #3951
Conversation
adam3smith
added some commits
Feb 24, 2019
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Feb 24, 2019
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
adam3smith
added some commits
Feb 24, 2019
rmzelle
reviewed
Feb 26, 2019
@@ -1,7 +1,7 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<style xmlns="http://purl.org/net/xbiblio/csl" class="note" version="1.0" demote-non-dropping-particle="sort-only" default-locale="en-GB"> | |||
<info> | |||
<title>Australian Guide to Legal Citation</title> | |||
<title>Australian Guide to Legal Citation, 4th Edition</title> |
This comment has been minimized.
This comment has been minimized.
rmzelle
Feb 26, 2019
Member
@adam3smith, minor nitpick, but we don't use a comma in any of our edition-versioned styles: https://www.zotero.org/styles?q=%20edition.
rmzelle
reviewed
Feb 26, 2019
<title-short>AGLC</title-short> | ||
<id>http://www.zotero.org/styles/australian-guide-to-legal-citation-3rd-edition</id> | ||
<link href="http://www.zotero.org/styles/australian-guide-to-legal-citation-3rd-edition" rel="self"/> | ||
<link href="https://forums.zotero.org/discussion/4841/new-australian-legal-citation-style/?Focus=20831#Comment_20831" rel="documentation"/> |
This comment has been minimized.
This comment has been minimized.
rmzelle
Feb 26, 2019
Member
This documentation link doesn't highlight a comment for me. Seems to be the old forums syntax. (@adam3smith, you're currently reusing this old link for the 4th edition)
rmzelle
reviewed
Feb 26, 2019
<?xml version="1.0" encoding="utf-8"?> | ||
<style xmlns="http://purl.org/net/xbiblio/csl" class="note" version="1.0" demote-non-dropping-particle="sort-only" default-locale="en-GB"> | ||
<info> | ||
<title>Australian Guide to Legal Citation</title> |
This comment has been minimized.
This comment has been minimized.
rmzelle
Feb 26, 2019
Member
Title should be updated to also say "3rd edition" (without a preceding comma, probably)
This comment has been minimized.
This comment has been minimized.
stale
bot
commented
Mar 28, 2019
This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks. |
stale
bot
added
the
waiting
label
Mar 28, 2019
stale
bot
closed this
Apr 11, 2019
adam3smith
reopened this
Apr 11, 2019
stale
bot
removed
the
waiting
label
Apr 11, 2019
adam3smith
marked this pull request as ready for review
Apr 11, 2019
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 11, 2019
|
rmzelle
added some commits
Apr 14, 2019
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 14, 2019
|
2 similar comments
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 14, 2019
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 14, 2019
|
This comment has been minimized.
This comment has been minimized.
Looks fine to me. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 16, 2019
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 16, 2019
|
adam3smith
merged commit e4dc24d
into
master
Apr 16, 2019
adam3smith
deleted the
aglc-4
branch
Apr 16, 2019
This comment has been minimized.
This comment has been minimized.
Thanks! :) |
adam3smith commentedFeb 24, 2019
No description provided.