Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create acta-ichthyologica-et-piscatoria.csl #4154

Merged
merged 2 commits into from Jun 25, 2019

Conversation

@POBrien333
Copy link
Contributor

commented Jun 21, 2019 •
edited by rmzelle

via https://forums.zotero.org/discussion/76794/style-request-acta-ichthyologica-et-piscatoria
@POBrien333
Create acta-ichthyologica-et-piscatoria.csl 
via https://forums.zotero.org/discussion/76794/style-request-acta-ichthyologica-et-piscatoria#latest
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
de1a440
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 21, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 21, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

acta-ichthyologica-et-piscatoria.csl (new)
(Hancké et al. 2007; 2012)
(Mares 2001; Fenner et al. 2019)
2012. CSL search by example. In: Citation Style Editor. . http://editor.citationstyles.org/searchByExample/. Accessed 15 Dec 2012.
Fenner M., Crosas M., Grethe J.S., et al. 2019. A data citation roadmap for scholarly data repositories. Scientific Data 6 (1): 28. DOI: 10.1038/s41597-019-0031-8
Hancké B., Rhodes M., Thatcher M. (eds). 2007. Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.
Mares I. 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? Pp. 184–213In: Hall P.A., Soskice D. (eds)Varieties of capitalism. The institutional foundations of comparative advantageOxford University Press, New York.
@rmzelle
Update acta-ichthyologica-et-piscatoria.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fbe886d
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 21, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

acta-ichthyologica-et-piscatoria.csl (new)
(Hancké et al. 2007; 2012)
(Mares 2001; Fenner et al. 2019)
2012. CSL search by example. In: Citation Style Editor. . http://editor.citationstyles.org/searchByExample/. Accessed 15 Dec 2012.
Fenner M., Crosas M., Grethe J.S., et al. 2019. A data citation roadmap for scholarly data repositories. Scientific Data 6 (1): 28. DOI: 10.1038/s41597-019-0031-8
Hancké B., Rhodes M., Thatcher M. (eds). 2007. Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.
Mares I. 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? Pp. 184–213In: Hall P.A., Soskice D. (eds)Varieties of capitalism. The institutional foundations of comparative advantageOxford University Press, New York.
@rmzelle

rmzelle reviewed Jun 21, 2019
View changes

acta-ichthyologica-et-piscatoria.csl
<link href="https://aiep.pl/main/instr.php" rel="documentation"/>
<author>
<name>Sebastian Karcher</name>
<name>Patrick O'Brien, PhD</name>
<email>obrienpat86@gmail.com</email>

This comment has been minimized.

Sign in to view
Copy link
@rmzelle

rmzelle Jun 21, 2019

Member

@adam3smith, @POBrien333, I assume Patrick just forgot to update the name here.
@POBrien333

POBrien333 reviewed Jun 21, 2019
View changes

Copy link
Contributor Author

left a comment

Yes, he did. Thanks for spotting and fixing :)
@adam3smith

adam3smith reviewed Jun 23, 2019
View changes

acta-ichthyologica-et-piscatoria.csl
<text macro="author" font-weight="bold"/>
<text macro="year"/>
<text macro="title"/>
<choose>

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jun 23, 2019

Member

Just an FYI if you're looking at the previews -- citeproc-ruby doesn't apply group delimiters within choose elements contained in the group. This is fine with other citeprocs and I think should be changed in citeproc-ruby (which is doing this technically correctly according to the specs) and it's definitely fine in the styles, so just mentioning this so you don't worry about it.

This comment has been minimized.

Sign in to view
Copy link
@rmzelle

rmzelle Jun 24, 2019

Member

This is fine with other citeprocs and I think should be changed in citeproc-ruby (which is doing this technically correctly according to the specs) and it's definitely fine in the styles, so just mentioning this so you don't worry about it.

My thinking about this has always been that style authors should be able to add <choose/> elements (e.g. to cover exceptions) without affecting the original functioning of the style, so yes, we should clarify this in the spec if needed and get citeproc-ruby to push the delimiter down into the <choose/> contents.

@adam3smith adam3smith merged commit 1398117 into citation-style-language:master Jun 25, 2019
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 25, 2019

Thanks!
@rmzelle rmzelle referenced this pull request Jun 30, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmzelle rmzelle

@adam3smith adam3smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@POBrien333 @csl-bot @adam3smith @rmzelle
You can’t perform that action at this time.