Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate helvetica-chimica-acta #4168
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 3, 2019
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 3, 2019
1 test failedThe CSL Style Repository may not contain extra files (make sure styles have a ".csl" extension)
Please check the test report for details. |
POBrien333
reviewed
Jul 4, 2019
<style xmlns="http://purl.org/net/xbiblio/csl" class="in-text" version="1.0" demote-non-dropping-particle="sort-only" default-locale="en-US"> | ||
<info> | ||
<title>Helvetica Chimica Acta</title> | ||
<id>http://www.zotero.org/styles/angewandte-chemie</id> |
This comment has been minimized.
This comment has been minimized.
POBrien333
Jul 4, 2019
Contributor
- change this line to match with your self link.
- And I guess angewande-chemie was your template style. Please add that below the self link with rel="template".
- add the .csl extension to your filename.
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 7, 2019
Below are some sample citations generated based on your proposed changes: helvetica-chimica-acta.csl (new)[1,2] |
rmzelle
reviewed
Jul 7, 2019
<issn>0018-019X</issn> | ||
<eissn>1522-2675</eissn> | ||
<summary>A style for Wiley-VCH's journal "Helvetica Chimica Acta" based on "Angewandte Chemie International Edition". | ||
This style has many limits due to csl constraints, most notably the inability to include pages/page ranges for books, the wrong square brackets for two items cited together, and the lack of support for citing 1a)... b)...c)....</summary> |
This comment has been minimized.
This comment has been minimized.
rmzelle
Jul 7, 2019
Member
This style has many limits due to csl constraints, most notably the inability to include pages/page ranges for books, the wrong square brackets for two items cited together, and the lack of support for citing 1a)... b)...c)....
@daenuprobst, can you describe the first two problems in more detail? We're aware of the third point, which is indeed currently not possible with CSL (citation-style-language/schema#36).
This comment has been minimized.
This comment has been minimized.
adam3smith
Jul 15, 2019
Member
- Refers to providing essentially a pinpoint to a specific passage in a book in a numeric style. CSL can kind of do this by using
text variable="page"
but that requires separate items every time you want to add a different part of a book, so isn't really feasible. That said, this isn't actually used in the style or in published articles, so removing it from the summary - The style using [1-2] instead of [1,2] which CSL can't do
- The style explicitly does not use composit (1a) b) c)) references, so I'll take this out of the summary, too.
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 15, 2019
Below are some sample citations generated based on your proposed changes: helvetica-chimica-acta.csl (new)[1,2] |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 15, 2019
Below are some sample citations generated based on your proposed changes: helvetica-chimica-acta.csl (new)[1,2] |
adam3smith
merged commit d14b62d
into
citation-style-language:master
Jul 15, 2019
1 check passed
This comment has been minimized.
This comment has been minimized.
Great, thanks! |
daenuprobst commentedJul 3, 2019
Was not yet available.