Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upCheck only modified files in CI #1900
Comments
This comment has been minimized.
This comment has been minimized.
This is possible. It'd build on work in #1895 though, and I'm in no hurry to do cross-branch work given recent experience. |
This comment has been minimized.
This comment has been minimized.
I don't think it'd require any changes when #1895 is done; adding a script line like
and then calling |
This comment has been minimized.
This comment has been minimized.
or just
in |
retorquere
added a commit
to retorquere/translators
that referenced
this issue
Mar 28, 2019
retorquere
added a commit
to retorquere/translators
that referenced
this issue
Mar 28, 2019
dstillman
closed this
in
f67b9c5
Mar 28, 2019
GuyAglionby
added a commit
to GuyAglionby/translators
that referenced
this issue
Mar 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dstillman commentedMar 7, 2019
Unless and until we go through all translators to fix linter errors (which I'm in no rush to do), we're never going to have passing tests. It would be more useful (and it would certainly be quicker) to run ESLint only against the files modified in the commit range, so that we can rely on the checks on GitHub without having to check the output.
#1895 probably needs to land first.
/cc @retorquere