Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes S #1343
Conversation
zuphilip
and others
added some commits
Jun 24, 2017
adam3smith
requested changes
Jun 25, 2017
A couple of small nits or questions |
@@ -2,14 +2,14 @@ | |||
"translatorID": "d21dcd90-c997-4e14-8fe0-353b8e19a47a", | |||
"label": "SAGE Knowledge", | |||
"creator": "ProQuest", |
This comment has been minimized.
This comment has been minimized.
} | ||
//Z.debug(citeLink) | ||
|
||
ZU.doGet(citeLink, function(text) { | ||
var re = /<textarea name="records".*?>([\s\S]*?)<\/textarea>/; |
This comment has been minimized.
This comment has been minimized.
.replace(/NV\s+-\s+1\n/, "") | ||
.replace(/^(AU\s+-\s+.+?),? Ph\.? ?D\.?\n/mg, '$1\n'); | ||
.replace(/^AU\s+-\s+,\s+$/m, '') |
This comment has been minimized.
This comment has been minimized.
adam3smith
Jun 25, 2017
Collaborator
This seems like you're deleting the entire Author field or what am I missing?
This comment has been minimized.
This comment has been minimized.
zuphilip
Jun 25, 2017
Author
Collaborator
Yes, but this is an empty author field, i.e. something like
AU - ,
(Note the beginning ^
and end of line $
characters in the regexp.)
This comment has been minimized.
This comment has been minimized.
adam3smith
Jun 25, 2017
Collaborator
ah didn't catch that these were just spaces and commas. Makes sense then.
"reportNumber": "ID 1450387", | ||
"reportType": "SSRN Scholarly Paper", | ||
"shortTitle": "Who Doesn't Support the Genocide Convention?", | ||
"url": "https://papers.ssrn.com/abstract=1450387", | ||
"attachments": [ | ||
{ | ||
"title": "Full Text PDF", |
This comment has been minimized.
This comment has been minimized.
adam3smith
Jun 25, 2017
Collaborator
curious: did you test if we are now able to download the PDF? (that didn't use to work)
This comment has been minimized.
This comment has been minimized.
zuphilip
Jun 25, 2017
Author
Collaborator
I tested this now, but PDFs are still not working. There are various problems why this does not work (and might not work easily):
- The url in the Highwire metadata is just pointing to the article itself, e.g.
<meta name="citation_pdf_url" content="https://papers.ssrn.com/sol3/Delivery.cfm?abstractid=1450387">
. - The url given on the website will answer with a 302 redirect to a temporary url, e.g. https://poseidon01.ssrn.com/delivery.php?ID=701020068111102101093115090073117106050051026007034010028119075074115030099102086074052006096099098123062123085114073109119015121051066022058093067123027007005102080025003000086073067112079109003084076125005103102023110012010105020103092022022025006090&EXT=pdf.
- To catch the 302 redirection we would need to read this information from the header, which I am not sure how to do that...
- After playing a little around with this one example, I receive now an SSRN Alert about an "unusual donwload pattern":
This comment has been minimized.
This comment has been minimized.
adam3smith
Jun 25, 2017
Collaborator
we should remove this, then -- otherwise it looks like a bug or something people should expect Zotero to do.
This comment has been minimized.
This comment has been minimized.
Please have a look at the new version. |
adam3smith
and others
added some commits
Jun 26, 2017
This comment has been minimized.
This comment has been minimized.
I removed the non-working PDF attachment in SSRN as you suggested. Please have a look. |
adam3smith
merged commit c250250
into
zotero:master
Jun 26, 2017
1 check passed
This comment has been minimized.
This comment has been minimized.
Thanks! |
zuphilip commentedJun 25, 2017
No description provided.