Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean export translators #1463

Merged
merged 3 commits into from Nov 7, 2017
+74 −68

Conversation

@zuphilip
Copy link
Collaborator

commented Nov 4, 2017 •
edited

This is just some cleanup and relates to zotero/zotero-connectors#197.

zuphilip added some commits Nov 4, 2017

@zuphilip
Delete browserSupport for export translators only 
The option browserSupport has not use for export translators only,
i.e. translators with translatorType 2. This option is already
missing for
* BibLaTeX.js
* TEI.js
* Zotero RDF.js
c501a20
@zuphilip
Fix spacing in some translators headers 
Found with
   grep 'translatorType":2' *.js
   grep 'translatorType":4' *.js
6c2d648
@zuphilip
Adjust target to our standards in two translators
Loading status checks…
cb22041

@adam3smith adam3smith merged commit 67eadc5 into zotero:master Nov 7, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented Nov 7, 2017

Thanks

@zuphilip zuphilip deleted the zuphilip:clean-export-translators branch Nov 7, 2017

psisquared2 added a commit to psisquared2/translators that referenced this pull request Feb 8, 2018

@zuphilip @psisquared2
Clean export translators (zotero#1463) 
* Delete browserSupport for export translators only

The option browserSupport has not use for export translators only,
i.e. translators with translatorType 2. This option is already
missing for
* BibLaTeX.js
* TEI.js
* Zotero RDF.js

* Fix spacing in some translators headers

Found with
   grep 'translatorType":2' *.js
   grep 'translatorType":4' *.js

* Adjust target to our standards in two translators
54c72a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zuphilip @adam3smith
You can’t perform that action at this time.