Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upExpand target in Primo 2018.js for PrimoVE #1670
Conversation
adam3smith
reviewed
Jun 1, 2018
Looks good. Do we need the parentheses at beginning and end? |
This comment has been minimized.
This comment has been minimized.
We don't need parentheses at the beginning and end because there is not prefix or suffix to the alternation. From https://www.regular-expressions.info/alternation.html :
|
zuphilip
merged commit fda2685
into
zotero:master
Jun 14, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
zuphilip
deleted the
zuphilip:PrimoVE
branch
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
zuphilip commentedJun 1, 2018
I could not test this, but that seems to be a different problem...