Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS URL fixes: The Guardian and JSTOR #1708

Merged
merged 4 commits into from Aug 11, 2018

Conversation

@owcz
Copy link
Contributor

commented Aug 11, 2018

Noticed that a Wikipedia bot was correcting some http links to https from my citations so I checked and realized that the translators were not preserving the https properly from the link URLs

The Guardian and JSTOR use https stable URLs but their respective OpenGraph and RIS data use the outdated http. Until they catch up, this fix saves the correct https URL to the citation. It also:

  • rewrites JSTOR's multi, which would break on journal issue ToCs, e.g., https://www.jstor.org/stable/i250748 (covers search and issue ToCs but test if I'm missing edge cases)
  • fixes a test on Wired, which should normally save https links
  • fixes The Observer detection, which was broken

owcz added some commits Aug 11, 2018

@owcz owcz changed the title https URLs fixes: The Guardian and JSTOR HTTPS URL fixes: The Guardian and JSTOR Aug 11, 2018

@adam3smith adam3smith merged commit bed3bc9 into zotero:master Aug 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Collaborator

commented Aug 11, 2018

Thanks -- something weird going on with the Wired translator, not sure what caused the merge conflict there.

@owcz owcz deleted the owcz:https branch Aug 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.