Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upWorldCat Discovery Service.js -- fix eslint warnings #1847
Conversation
adam3smith
merged commit 56182d1
into
zotero:master
Feb 25, 2019
1 check passed
This comment has been minimized.
This comment has been minimized.
You're a hero slogging through all of these! |
retorquere
deleted the
retorquere:WorldCat_Discovery_Service
branch
Feb 25, 2019
This comment has been minimized.
This comment has been minimized.
I needed something to take my mind off. This is about as Zen as it gets |
This comment has been minimized.
This comment has been minimized.
Thanks a lot for doing this, but I would actually hold off before going through more of these. As I noted, we have a much larger ESLint config that we might want to apply to this repo (and most of our repos). I just added that config recently, so there may be some additional tweaks to make (and the warn/error distinction is somewhat arbitrary at this point), but it should mostly describe the bulk of existing Zotero code. Whether that matters for translator is up for debate, but it could certainly address things like this (I also suggested that we shouldn't do mass edits for style changes and translator authors should just fix them in separate commits when they update styles. Conflicts are much less of an issue here, though, so if @adam3smith and @zuphilip don't mind the extra churn, I'm OK with going through these now. But it doesn't make sense to do it more than once.) |
This comment has been minimized.
This comment has been minimized.
(And one reason to do them along with other translator changes, after expanding the config, is that more intensive checking is likely to reveal actual bugs that need to be investigated and tested against the site.) |
This comment has been minimized.
This comment has been minimized.
I'm OK holding off, it's mostly a papercuts issue for me. I reckon though that whatever edits I make now are going to have to be done in any case. One argument I could offer for doing it anyhow is that most translators seem to be copy-and-change jobs, so whatever code problems exist are more likely to proliferate. But I'll stop sending in pull requests for now. |
This comment has been minimized.
This comment has been minimized.
Those bugs would be unearthed by heavier linting in any case -- if you look at the But as said, I'll stop for now. Feel free to holler when the new lint config is in place -- code tidying is relaxing work for me right now. |
retorquere commentedFeb 25, 2019
No description provided.