Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: pulse #1539
Comments
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @melund, @trallard it looks like you're currently assigned to review this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @melund your reviewer checklist is at the top 👆🏼 thanks a lot for your time and effort. As per usual if you run into any problems feel free to ping me here! |
This comment has been minimized.
This comment has been minimized.
Thanks, @trallard. I may be a little while before I can get to this. I am going on sommer holiday on Friday. And I will most likely be away from my computer for at least two weeks. I am sorry, but I am just too busy before I leave to get this done. I will look at it when I get back :) |
whedon
assigned
melund
Jul 2, 2019
This comment has been minimized.
This comment has been minimized.
Hi @melund just checking how you are doing? I am planning to move this forward this week - early the next |
This comment has been minimized.
This comment has been minimized.
@trallard I am traveling in Asia and I only have my phone. I am back in a week and then I will try to get look at this. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Reminder set for @melund in 2 weeks |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
/ooo July 25 to August 19 |
This comment has been minimized.
This comment has been minimized.
ooo
bot
commented
Jul 25, 2019
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
I am done with my review. I think pulse more than qualifies for JOSS. It is a really good example of how to structure an open-source software project. With the recent addition of conda-forge package, I am also sure that the library will continue to work in the future. All in all, nice work @finsberg |
This comment has been minimized.
This comment has been minimized.
Thanks @melund Can you please make sure to perform the following actions:
|
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@whedon check references |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon set 10.5281/zenodo.3376811 as archive |
This comment has been minimized.
This comment has been minimized.
OK. 10.5281/zenodo.3376811 is the archive. |
This comment has been minimized.
This comment has been minimized.
@whedon set 2019.0 as version |
This comment has been minimized.
This comment has been minimized.
OK. 2019.0 is the version. |
This comment has been minimized.
This comment has been minimized.
@finsberg I have completed my editorial checks and I am willing to recommend this for publication @melund thanks for your contribution as a reviewer 🙌🏼 @openjournals/jose-eics I am passing this submission to you for acceptance |
trallard
added
the
accepted
label
Sep 24, 2019
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Sep 24, 2019
@whedon accept |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Check final proof If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#978, then you can now move forward with accepting the submission by compiling again with the flag
|
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Sep 24, 2019
|
This comment has been minimized.
This comment has been minimized.
Thanks for the heads up @danielskatz. I have been following the instructions at https://joss.readthedocs.io/en/latest/editing.html#after-acceptance where it says the editor should add the |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Sep 24, 2019
|
This comment has been minimized.
This comment has been minimized.
@danielskatz Done |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Sep 24, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Sep 24, 2019
@whedon accept |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Check final proof If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#979, then you can now move forward with accepting the submission by compiling again with the flag
|
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Sep 24, 2019
@whedon accept deposit=true |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Here's what you must now do:
Any issues? notify your editorial technical team... |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Sep 24, 2019
danielskatz
closed this
Sep 24, 2019
This comment has been minimized.
This comment has been minimized.
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
whedon commentedJul 1, 2019
•
edited
Submitting author: @finsberg (Henrik Nicolay Topnes Finsberg)
Repository: https://github.com/finsberg/pulse
Version: 2019.0
Editor: @trallard
Reviewer: @melund, @trallard
Archive: 10.5281/zenodo.3376811
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@melund & @trallard , please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @trallard know.
Review checklist for @melund
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @trallard
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?