Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdates for 0.18.0 release #137
Conversation
ruebot
requested review from
ianmilligan1 and
SamFritz
Sep 10, 2019
ianmilligan1
requested changes
Sep 10, 2019
Since the documentation disappearing is going to throw off a few people, I think we should add a banner message at the top of this page or below the image along these lines:
We don't need that banner forever (maybe drop it when 19 or 20 comes out), but people will inevitably not read the small print so best to put it front and centre. Now that it's more of a stub page, we might also want to replace the banner image of Internet Archive servers with one of the screenshots of the Toolkit in action, something like this one. |
ianmilligan1
approved these changes
Sep 10, 2019
Looks good to me. Once we get @SamFritz's |
SamFritz
approved these changes
Sep 10, 2019
Looks good! |
ianmilligan1
merged commit a82b29e
into
master
Sep 11, 2019
ianmilligan1
deleted the
aut-18
branch
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedSep 10, 2019