New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed something for #208. #282

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@ruebot
Member

ruebot commented Oct 17, 2018

Follow-up to #211

@ruebot ruebot requested a review from ianmilligan1 Oct 17, 2018

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 17, 2018

Codecov Report

Merging #282 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   70.36%   70.36%           
=======================================
  Files          41       41           
  Lines        1046     1046           
  Branches      192      192           
=======================================
  Hits          736      736           
  Misses        244      244           
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe05a5...cb6433f. Read the comment docs.

codecov-io commented Oct 17, 2018

Codecov Report

Merging #282 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   70.36%   70.36%           
=======================================
  Files          41       41           
  Lines        1046     1046           
  Branches      192      192           
=======================================
  Hits          736      736           
  Misses        244      244           
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe05a5...cb6433f. Read the comment docs.

@ianmilligan1 ianmilligan1 merged commit 6b4ef94 into archivesunleashed:master Oct 17, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 4fe05a5...cb6433f
Details
codecov/project 70.36% remains the same compared to 4fe05a5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ruebot ruebot deleted the ruebot:issue-208-b branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment