Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing the OPTIONAL for dates in query for recent publications #726

Merged
merged 1 commit into from May 26, 2019

Conversation

Projects
None yet
2 participants
@Daniel-Mietchen
Copy link
Collaborator

commented May 26, 2019

No description provided.

@Daniel-Mietchen Daniel-Mietchen merged commit c468232 into master May 26, 2019

1 check passed

security/snyk - requirements.txt (fnielsen) No manifest changes detected

@Daniel-Mietchen Daniel-Mietchen deleted the Daniel-Mietchen-patch-1 branch May 26, 2019

@fnielsen

This comment has been minimized.

Copy link
Owner

commented May 27, 2019

What was the rational for this change?

@Daniel-Mietchen

This comment has been minimized.

Copy link
Collaborator Author

commented May 27, 2019

"Recent" implies some sort of time, but that does not make much sense if P577 is not set. Plus, for people with more than 10 publications, those entries without P577 would not show up in the default view anyway.

The trigger for me to look into this was #727 (i.e. oldest publications).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.