Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Bug report template. #268
Conversation
ruebot
requested review from
greebie,
lintool,
ianmilligan1 and
SamFritz
Sep 5, 2018
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Sep 6, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
=======================================
Coverage 70.35% 70.35%
=======================================
Files 41 41
Lines 1039 1039
Branches 191 191
=======================================
Hits 731 731
Misses 242 242
Partials 66 66Continue to review full report at Codecov.
|
ianmilligan1
requested changes
Sep 6, 2018
|
Excellent call (yeah, probably not too many people running AUT from their iPhones eh?). Just two minor suggestions here, not wedded to either. |
| - Browser: [e.g. stock browser, safari] | ||
| - Version: [e.g. 22] | ||
| **Environment information** | ||
| - aut version: [e.g. 0.16.0, HEAD] |
This comment has been minimized.
This comment has been minimized.
ianmilligan1
Sep 6, 2018
Member
We tend to capitalize aut as AUT throughout our docs, could we change it here for consistency?
| - OS: [e.g. MacOS 10.13.3, Ubuntu 18.04] | ||
| - Java version: [e.g. Java 8] | ||
| - Apache Spark version: [e.g 2.1.3, 2.3.1] | ||
| - Apache Spark w/aut: [e.g. --jars, --packages] |
This comment has been minimized.
This comment has been minimized.
ianmilligan1
Sep 6, 2018
Member
maybe make even clearer what we want
-Apache Spark command used to run AUT: [e.g ./spark-shell --driver-memory 55G --packages "io.archivesunleashed:aut:0.16.0"]
That'd be useful to know - i.e. to get the full context of what they're doing.
ianmilligan1
approved these changes
Sep 6, 2018
SamFritz
approved these changes
Sep 10, 2018
| - AUT version: [e.g. 0.16.0, HEAD] | ||
| - OS: [e.g. MacOS 10.13.3, Ubuntu 18.04] | ||
| - Java version: [e.g. Java 8] | ||
| - Apache Spark version: [e.g 2.1.3, 2.3.1] |
This comment has been minimized.
This comment has been minimized.
SamFritz
Sep 10, 2018
Member
I think the changes to the template work really well @ruebot. Two tiny tweaks to offer:
e.g --> e.g.
| - Java version: [e.g. Java 8] | ||
| - Apache Spark version: [e.g 2.1.3, 2.3.1] | ||
| - Apache Spark w/aut: [e.g. --jars, --packages] | ||
| - Apache Spark command used to run AUT: [e.g ./spark-shell --driver-memory 55G --packages "io.archivesunleashed:aut:0.16.0"] |
This comment has been minimized.
This comment has been minimized.
ruebot
force-pushed the
issue-template-update
branch
from
858809d
to
f07e276
Sep 10, 2018
ianmilligan1
merged commit c95a51d
into
master
Sep 10, 2018
4 checks passed
ianmilligan1
deleted the
issue-template-update
branch
Sep 10, 2018
ruebot commentedSep 5, 2018
GitHub issue(s): none
What does this Pull Request do?
Updating our bug report template to tease out more information that is necessary for helping troubleshoot and diagnose issues. Remove some stuff that I didn't really feel mattered. Bit of a shortcoming I noticed with #267.
How should this be tested?
Read it, and see if you agree with it.