Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade rubocop-rspec to version 1.36.0 #85

Merged
merged 2 commits into from Sep 29, 2019

Conversation

@depfu
Copy link
Contributor

commented Sep 28, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (~> 1.35.0 → ~> 1.36.0) · Repo · Changelog

Release Notes

1.36.0

  • Fix RSpec/DescribedClass's error when described_class is used as part of a constant. (@pirj)
  • Fix RSpec/ExampleWording autocorrect of multi-line docstrings. (@pirj)
  • Add RSpec/ContextMethod cop, to detect method names in context. (@geniou)
  • Update RuboCop dependency to 0.68.1 with support for children matching node pattern syntax. (@pirj)
  • Add RSpec/EmptyLineAfterExample cop to check that there is an empty line after example blocks. (@pirj)
  • Fix Capybara/CurrentPathExpectation auto-corrector, to include option ignore_query: true. (@onumis)
  • Fix RSpec/Focus detecting mixed array/hash metadata. (@dgollahon)
  • Fix RSpec/Focus to also detect pending examples. (@dgollahon)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 34 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
@depfu depfu bot added the depfu label Sep 28, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 29, 2019

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #85   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b96fc1...1e65be7. Read the comment docs.

@ruebot ruebot merged commit b783608 into master Sep 29, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 6b96fc1...1e65be7
Details
codecov/project 100% remains the same compared to 6b96fc1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@depfu depfu bot deleted the depfu/update/rubocop-rspec-1.36.0 branch Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.