Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPatch for #277: Fix bug and unit test for ExtractDomain #278
Conversation
borislin
requested a review
from
greebie
Oct 16, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
codecov-io
Oct 16, 2018
Codecov Report
Merging #278 into master will not change coverage.
The diff coverage is100%.
@@ Coverage Diff @@
## master #278 +/- ##
=======================================
Coverage 70.36% 70.36%
=======================================
Files 41 41
Lines 1046 1046
Branches 192 192
=======================================
Hits 736 736
Misses 244 244
Partials 66 66| Impacted Files | Coverage Δ | |
|---|---|---|
| .../io/archivesunleashed/matchbox/ExtractDomain.scala | 87.5% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 4fe05a5...8150fc6. Read the comment docs.
codecov-io
commented
Oct 16, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
=======================================
Coverage 70.36% 70.36%
=======================================
Files 41 41
Lines 1046 1046
Branches 192 192
=======================================
Hits 736 736
Misses 244 244
Partials 66 66
Continue to review full report at Codecov.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@borislin can you update this branch? |
ruebot
approved these changes
Oct 17, 2018
Tested and good to go.
Just need to update the branch. Once that happens, I'll get this merged.
borislin commentedOct 16, 2018
This PR fixes the wrong order of
urlandsourcechecking inExtractDomain.GitHub issue(s):
What does this Pull Request do?
This PR improves unit test for
ExtractDomainto catch a bug whereExtractDomainmistakenly checkssourcefirst thenurl, and also fixes the bug by reversing the checking order ofsourceandurl.How should this be tested?
git fetch --allgit checkout fix-extractdomainmvn clean packageInterested parties
@lintool @greebie @ruebot