Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove Deprecated ExtractGraph app #293
Conversation
greebie
added some commits
Nov 22, 2018
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Nov 28, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
==========================================
+ Coverage 73.39% 75.76% +2.36%
==========================================
Files 42 41 -1
Lines 1184 1147 -37
Branches 210 202 -8
==========================================
Hits 869 869
+ Misses 244 209 -35
+ Partials 71 69 -2Continue to review full report at Codecov.
|
ianmilligan1
approved these changes
Nov 28, 2018
Builds nicely locally too.
I don't think we've had any real use of the ExtractGraph functionality, and there's the newer ExtractGraphX. Given all this, I think this is a good removal for 0.18.
This comment has been minimized.
This comment has been minimized.
|
And just to link this to the PR where the deprecated notice was included, so this shouldn't be a surprise to anybody: https://github.com/archivesunleashed/aut/pull/245/files |
greebie commentedNov 28, 2018
GitHub issue(s):
#291
What does this Pull Request do?
Removes ExtractGraph which was previously deprecated. ExtractGraphX is the current replacement.
How should this be tested?
Travis / codecov should suffice.
Interested parties
@ianmilligan1 @ruebot
Thanks in advance for your help with the Archives Unleashed Toolkit!