Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upLog closing of ARC and WARC files, per #156 #301
Conversation
jrwiebe
added some commits
Jan 29, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Jan 30, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
==========================================
+ Coverage 75.76% 75.84% +0.08%
==========================================
Files 41 41
Lines 1147 1151 +4
Branches 202 202
==========================================
+ Hits 869 873 +4
Misses 209 209
Partials 69 69
Continue to review full report at Codecov.
|
ianmilligan1
approved these changes
Jan 30, 2019
Tested locally on a set of WARCs and the the |
ianmilligan1
requested a review
from
ruebot
Jan 30, 2019
This comment has been minimized.
This comment has been minimized.
Once I get a |
ruebot
merged commit fc0178d
into
master
Jan 31, 2019
ruebot
deleted the
log-warc-open-close
branch
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jrwiebe commentedJan 30, 2019
GitHub issue(s): #156
What does this Pull Request do?
How should this be tested?
In Spark shell:
The logs should contain something similar to this:
Additional Notes:
Interested parties
@dportabella