Skip to content

/aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace computeHash with ComputeMD5; resolves #333. #338

Merged
merged 2 commits into from Aug 7, 2019
+25 −31

Conversation

@ruebot
Copy link
Member

commented Aug 7, 2019 •
edited

GitHub issue(s): #333

What does this Pull Request do?

Replace computeHash with ComputeMD5.

How should this be tested?

  • TravisCI MUST pass
  • Probably a bit of sanity tests if anybody has time

Additional Notes:

This seems sloppy, but if y'all don't think it is, then it isn't 😉
@ruebot
Replace computeHash with ComputeMD5; resolves #333.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
51ad2be

@ruebot ruebot requested review from ianmilligan1 and jrwiebe Aug 7, 2019

@codecov-io

This comment has been minimized.

Sign in to view
Copy link

commented Aug 7, 2019 •
edited

Codecov Report

❗️ No coverage uploaded for pull request base (master@1818596). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #338   +/-   ##
=========================================
  Coverage          ?   74.95%           
=========================================
  Files             ?       39           
  Lines             ?     1122           
  Branches          ?      197           
=========================================
  Hits              ?      841           
  Misses            ?      214           
  Partials          ?       67
Impacted Files Coverage Δ
.../scala/io/archivesunleashed/matchbox/package.scala 88.88% <ø> (ø)
...c/main/scala/io/archivesunleashed/df/package.scala 95.23% <100%> (ø)
...ain/scala/io/archivesunleashed/app/WriteGEXF.scala 100% <100%> (ø)
...in/scala/io/archivesunleashed/app/WriteGraph.scala 98.38% <100%> (ø)
...ala/io/archivesunleashed/matchbox/ComputeMD5.scala 100% <100%> (ø)
.../scala/io/archivesunleashed/app/WriteGraphML.scala 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1818596...295a1e4. Read the comment docs.
@ruebot
I suppose these are redundant.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
295a1e4
@ianmilligan1

ianmilligan1 approved these changes Aug 7, 2019
View changes

Copy link
Member

left a comment

Reviewed with both docs as well as the new WriteGraph commands - all checks out. If @jrwiebe gives thumbs up he can merge or I can.

@jrwiebe jrwiebe merged commit 9623c7a into master Aug 7, 2019
3 checks passed

3 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jrwiebe jrwiebe deleted the issue-333 branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianmilligan1 ianmilligan1

@jrwiebe jrwiebe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ruebot @codecov-io @ianmilligan1 @jrwiebe
You can’t perform that action at this time.