Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMatchbox utilities to DataFrames #380
+11
−3
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Nov 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
==========================================
+ Coverage 76.16% 76.23% +0.06%
==========================================
Files 40 40
Lines 1418 1422 +4
Branches 268 268
==========================================
+ Hits 1080 1084 +4
Misses 221 221
Partials 117 117 |
This comment has been minimized.
This comment has been minimized.
Solid. Let's make that small tweak, and I'll merge. Thanks @SinghGursimran!
|
|
||
val ComputeMD5DF = udf((content: String) => io.archivesunleashed.matchbox.ComputeMD5.apply(content.getBytes())) | ||
|
||
val ComputeSHA1 = udf((content: String) => io.archivesunleashed.matchbox.ComputeSHA1.apply(content.getBytes())) |
This comment has been minimized.
This comment has been minimized.
ruebot
Nov 18, 2019
Member
I'm thinking we should add DF
to the end of this one as well, so it will potentially cut down on confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SinghGursimran commentedNov 17, 2019
Extended matchbox utilities to df
Issue: #223
For Testing: