Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate issue templates #216
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ruebot
May 2, 2018
Member
Let me know if anything needs to be tweaked. If so, I'll update auk, and warclight.
Let me know if anything needs to be tweaked. If so, I'll update auk, and warclight. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
codecov
bot
May 2, 2018
Codecov Report
Merging #216 into master will not change coverage.
The diff coverage isn/a
.
@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 66.16% 66.16%
=======================================
Files 34 34
Lines 665 665
Branches 124 124
=======================================
Hits 440 440
Misses 184 184
Partials 41 41
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 505c47a...48a44cc. Read the comment docs.
codecov
bot
commented
May 2, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 66.16% 66.16%
=======================================
Files 34 34
Lines 665 665
Branches 124 124
=======================================
Hits 440 440
Misses 184 184
Partials 41 41 Continue to review full report at Codecov.
|
ruebot
requested review from
ianmilligan1 and
SamFritz
May 2, 2018
ianmilligan1
requested changes
May 2, 2018
This looks fantastic. I just had a few minor suggestions which you can take or leave.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
SamFritz
May 2, 2018
Member
Looks great @ruebot!
Just a quick question: what happens in the workflow if a user wants to request a feature (e.g. for AUK) but doesn't have GitHub account? I know we want to encourage everyone to fill out the template through Git, but just thinking about someone who may only be using AUK through the GUI.
(this may be a questions for down the line).
Looks great @ruebot! Just a quick question: what happens in the workflow if a user wants to request a feature (e.g. for AUK) but doesn't have GitHub account? I know we want to encourage everyone to fill out the template through Git, but just thinking about someone who may only be using AUK through the GUI. (this may be a questions for down the line). |
SamFritz
approved these changes
May 2, 2018
Looks great @ruebot! Examples given are very helpful!
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ruebot
May 2, 2018
Member
@SamFritz Slack or email? Then we could create an issue. Good question though.
@SamFritz Slack or email? Then we could create an issue. Good question though. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ianmilligan1
May 2, 2018
Member
Good point! If they click "new issue" w/o an account they'll get this.
So maybe in places on the platform, etc. where we provide a link to "open an issue," we could also have an invitation to join our Slack group or e-mail us?
If that sounds good, we can merge this and keep this in mind for places where we invite people to open issues?
Good point! If they click "new issue" w/o an account they'll get this. So maybe in places on the platform, etc. where we provide a link to "open an issue," we could also have an invitation to join our Slack group or e-mail us? If that sounds good, we can merge this and keep this in mind for places where we invite people to open issues? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
SamFritz
May 2, 2018
Member
I think email might be easier to manage (in terms of documenting specific cases/instances of features/bugs, Slack blends all conversations together). But I also realize that more and more people are on Slack. :)
Merge sounds good!
I think email might be easier to manage (in terms of documenting specific cases/instances of features/bugs, Slack blends all conversations together). But I also realize that more and more people are on Slack. :) Merge sounds good! |
ruebot commentedMay 2, 2018
No description provided.