Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[PRE REVIEW]: feign: a Python package to estimate geometric efficiency in passive gamma spectroscopy measurements of nuclear fuel #1649
Comments
whedon
added
the
pre-review
label
Aug 15, 2019
whedon
assigned
katyhuff
Aug 15, 2019
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @katyhuff it looks like you're currently assigned as the editor for this paper For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
What happens now? This submission is currently in a You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here. |
This comment has been minimized.
This comment has been minimized.
|
whedon
added
Python
Shell
TeX
labels
Aug 15, 2019
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1649 with the following error: Error reading bibliography ./paper.bib (line 17, column 1): |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 15, 2019
|
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 15, 2019
|
This comment has been minimized.
This comment has been minimized.
I can definitely take this one. Thanks @danielskatz . @ezsolti : We can begin requesting reviewers when ezsolti/feign#6 is merged and when you are happy with the PDF that builds from |
This comment has been minimized.
This comment has been minimized.
ezsolti
commented
Aug 15, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ezsolti
commented
Aug 15, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ezsolti
commented
Aug 15, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ezsolti
commented
Aug 15, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ezsolti
commented
Aug 15, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ezsolti
commented
Aug 15, 2019
@katyhuff : Hello! Thank you for taking care of the paper. I reached a pdf what I'm more or less satisfied with (besides that a cite to a conference paper doesn't want to render correctly, what ever I do). |
This comment has been minimized.
This comment has been minimized.
@ezsolti : Ok -- I'll start asking for reviewers. (nonproliferation and safeguards suggestions are just as welcome as anyone else, so don't hesitate to suggest anyone.). How would you like the citation to render? |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
ezsolti
commented
Aug 15, 2019
@katyhuff : In that case Stefano Vaccaro (author of one of the cited papers: https://www.sciencedirect.com/science/article/pii/S0168900216307707) might be a good candidate. For the 'Partial defect identification in PWR spent fuel using Passive Gamma Spectroscopy' paper the Proceedings doesn't want to appear, also when referenced all surnames appear instead of (Elter et al., 2018). |
This comment has been minimized.
This comment has been minimized.
kellyrowland
commented
Aug 15, 2019
Hi @katyhuff , thanks for reaching out - I am interested in and able to take on this review. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@whedon assign @kellyrowland as reviewer |
whedon
assigned
katyhuff and
kellyrowland and unassigned
katyhuff
Aug 15, 2019
This comment has been minimized.
This comment has been minimized.
OK, the reviewer is @kellyrowland |
This comment has been minimized.
This comment has been minimized.
Thank you @kellyrowland! I'll ping you when we have enough reviewers to begin the review. Thank you @ezsolti : Thank you for your suggestion, I'll look into including Stefano Vaccaro as a reviewer. |
This comment has been minimized.
This comment has been minimized.
sskutnik
commented
Aug 15, 2019
Hi @katyhuff I'd be happy to serve as a reviewer. |
This comment has been minimized.
This comment has been minimized.
Fantastic @sskutnik , thank you. |
This comment has been minimized.
This comment has been minimized.
whedon
assigned
katyhuff,
kellyrowland and
sskutnik and unassigned
katyhuff and
kellyrowland
Aug 15, 2019
This comment has been minimized.
This comment has been minimized.
OK, @sskutnik is now a reviewer |
This comment has been minimized.
This comment has been minimized.
@whedon start review |
This comment has been minimized.
This comment has been minimized.
OK, I've started the review over in #1650. Feel free to close this issue now! |
This comment has been minimized.
This comment has been minimized.
Ok, folks, let's move over to #1650 to conduct the review. In that issue, each of you have a checklist. Please make sure that you have notifications turned on in issue #1650 and that you have at some point completed the reviewer signup form. https://joss.theoj.org/reviewer-signup.html |
whedon commentedAug 15, 2019
•
edited
Submitting author: @ezsolti (Zsolt Elter)
Repository: https://github.com/ezsolti/feign/
Version: v1.0.0
Editor: @katyhuff
Reviewers: @kellyrowland, @sskutnik
Author instructions
Thanks for submitting your paper to JOSS @ezsolti. The JOSS editor @katyhuff, will work with you on this issue to find a reviewer for your submission before creating the main review issue.
@ezsolti if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type: