Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keep and discard by http status. #347

Open
wants to merge 1 commit into
base: master
from

Conversation

@ruebot
Copy link
Member

commented Aug 17, 2019

GitHub issue(s): #315

What does this Pull Request do?

  • Add keep and discard by http status RecordLoader
  • Add tests
  • Clean up/add doc comments in RecordLoader
  • Resolve #315

How should this be tested?

  • Unit tests + TravisCI should take care of it.

@ruebot ruebot requested a review from ianmilligan1 Aug 17, 2019

@ruebot ruebot force-pushed the issue-315 branch from b1fc950 to 77b9990 Aug 17, 2019

Add keep and discard by http status.
- Add keep and discard by http status RecordLoader
- Add tests
- Clean up/add doc comments in RecordLoader
- Resolve #315

@ruebot ruebot force-pushed the issue-315 branch from 77b9990 to 5a4263a Aug 17, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 17, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@c824ad8). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master    #347   +/-   ##
========================================
  Coverage          ?   71.7%           
========================================
  Files             ?      38           
  Lines             ?    1428           
  Branches          ?     331           
========================================
  Hits              ?    1024           
  Misses            ?     245           
  Partials          ?     159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.