Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Ansible deprecation notices. #7

Open
wants to merge 1 commit into
base: master
from

Conversation

@ruebot
Copy link
Contributor

commented Aug 16, 2019

GitHub Issue: Islandora-CLAW/CLAW#1251

What does this Pull Request do?

Moves around yaml array items to address Ansible deprecation notices.

What's new?

Nothing.

How should this be tested?

vagrant up with this PR updates, and make sure you don't see the deprecation notices outlined in Islandora-CLAW/CLAW#1251

You will want:

This:

TASK [Islandora-Devops.grok : Install Grok dependencies (apt)] *****************
Friday 16 August 2019  13:54:50 -0400 (0:00:00.033)       0:57:18.937 ********* 
changed: [default]

TASK [Islandora-Devops.grok : Install Grok dependencies (yum)] *****************
Friday 16 August 2019  13:55:01 -0400 (0:00:10.934)       0:57:29.872 ********* 
skipping: [default]

Not this:

TASK [Islandora-Devops.grok : Install Grok dependencies (apt)] *****************
Friday 16 August 2019  12:36:28 -0400 (0:00:00.033)       0:54:49.202 ********* 
[DEPRECATION WARNING]: Invoking "apt" only once while using a loop via 
squash_actions is deprecated. Instead of using a loop to supply multiple items 
and specifying `name: "{{ item }}"`, please use `name: ['cmake', 'libpng-dev', 
'libtiff-dev', 'liblcms2-dev']` and remove the loop. This feature will be 
removed in version 2.11. Deprecation warnings can be disabled by setting 
deprecation_warnings=False in ansible.cfg.
changed: [default] => (item=[u'cmake', u'libpng-dev', u'libtiff-dev', u'liblcms2-dev'])

TASK [Islandora-Devops.grok : Install Grok dependencies (yum)] *****************
Friday 16 August 2019  12:36:39 -0400 (0:00:11.281)       0:55:00.484 ********* 
[DEPRECATION WARNING]: Invoking "yum" only once while using a loop via 
squash_actions is deprecated. Instead of using a loop to supply multiple items 
and specifying `name: "{{ item }}"`, please use `name: ['cmake3', 'libpng-
devel', 'libtiff-devel', 'lcms2-devel']` and remove the loop. This feature will
 be removed in version 2.11. Deprecation warnings can be disabled by setting 
deprecation_warnings=False in ansible.cfg.
skipping: [default] => (item=[]) 

Interested parties

@Islandora-Devops/committers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.