👍

From @matthewperry -- https://github.com/Islandora-Labs/islandora_image_annotation/blob/7.x/includes/utils.inc#L87-L91

Looks like we have deeper connections, and it's not a straightforward deprecation as I initially thought. We should probably have a conversation on a committers call about how to proceed with this?

tags @manez

@matthewperry wanna give this a test?

@nigelgbanks do we need to yank out even more w/r/t shared canvas:

./islandora_image_annotation.module:    // system, as it's really just a hold over from the past when shared canvas
./islandora_image_annotation.module:    'islandora_image_annotation_shared_canvas_logo' => array(
./css/islandora_image_annotation.logo.css:#islandora-image-annotation-shared-canvas-logo {
./css/islandora_image_annotation.logo.css:#islandora-image-annotation-shared-canvas-logo img {
./LICENSE.txt:the work, and the source code for shared libraries and dynamically
./theme/theme.inc:    '#theme' => 'islandora_image_annotation_shared_canvas_logo',
./theme/theme.inc:function theme_islandora_image_annotation_shared_canvas_logo() {
./theme/theme.inc:    'id' => 'islandora-image-annotation-shared-canvas-logo',
./js/islandora_image_annotation_canvas.js:      // Change made to support embedding shared canvas.
./js/islandora_image_annotation_canvas.js:     * Original version of shared Canvas apparently supported text and audio

We no longer share much code at all with the original shared canvas, I don't mind removing the Logo to reflect that, and I understand it's a 'dead' project in that it now represents something else. So ... yes we can remove more?

@nigelgbanks how about this, and other commented stuff in islandora_image_annotation.module?

It was just marked as deprecated on September 26th (it wasn't before).

https://github.com/ruebot/islandora_image_annotation/commit/d23edb23ac68c6fdac1287be3c6ab011871434e9

We're probably safe in removing though, and I'm nonplussed if we don't follow protocol in this case.

@nigelgbanks yeah, it's in Labs now. So a bit of wild west in terms of protocol 😨

I'll leave it for now, unless you or any of the other @Islandora-Labs/committers think I should remove it.

I'm gonna close this. Almost 4 years later, doesn't really seem necessary 😆