Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: molic: An R package for multivariate outlier detection in contingency tables #1653

Open
whedon opened this issue Aug 16, 2019 · 40 comments

Comments

@whedon
Copy link
Collaborator

commented Aug 16, 2019

Submitting author: @mlindsk (Mads Lindskou)
Repository: https://github.com/mlindsk/molic
Version: v0.5.0
Editor: @csoneson
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @mlindsk. Currently, there isn't an JOSS editor assigned to your paper.

@mlindsk if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label Aug 16, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 16, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 16, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 16, 2019

PDF failed to compile for issue #1653 with the following error:

Error producing PDF.
! LaTeX Error: File `algorithm.sty' not found.

Type X to quit or to proceed,
or enter new name. (Default extension: sty)

Enter file name:
! Emergency stop.
<read *>

l.255 \usepackage

Looks like we failed to compile the PDF

@danielskatz

This comment has been minimized.

Copy link

commented Aug 16, 2019

@mlindsk - it looks like a file is missing. Please enter @whedon generate pdf as a new comment in this issue to instruct whedon to try again, and iterate until the paper compiles.

@mlindsk

This comment has been minimized.

Copy link

commented Aug 16, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 16, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 16, 2019

PDF failed to compile for issue #1653 with the following error:

Error producing PDF.
! LaTeX Error: File `algorithm.sty' not found.

Type X to quit or to proceed,
or enter new name. (Default extension: sty)

Enter file name:
! Emergency stop.
<read *>

l.255 \usepackage

Looks like we failed to compile the PDF

@mlindsk

This comment has been minimized.

Copy link

commented Aug 16, 2019

@danielskatz I have looked for information on the use of external latex packages in paper.md but failed. Is it not possible to include such packages as the latex algorithm package?

@danielskatz

This comment has been minimized.

Copy link

commented Aug 16, 2019

👋 @arfon?

@arfon

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

@danielskatz I have looked for information on the use of external latex packages in paper.md but failed. Is it not possible to include such packages as the latex algorithm package?

We generally don't support custom packages with the paper build. Can you tell me what you're trying to achieve here, and could it be accomplished with regular (LaTeX) maths syntax?

@mlindsk

This comment has been minimized.

Copy link

commented Aug 16, 2019

I am trying to display a pseudo algorithm in the algorithmics environment which cannot be done in regular latex. If it's a hassle I can certainly find other ways to achieve something similar. I just like the format.

@danielskatz

This comment has been minimized.

Copy link

commented Aug 17, 2019

Can you go ahead and do this in another way?

@mlindsk

This comment has been minimized.

Copy link

commented Aug 17, 2019

Yes sure. I will try to make a standalone tex file for the algorithm and convert to png.

@mlindsk

This comment has been minimized.

Copy link

commented Aug 17, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

PDF failed to compile for issue #1653 with the following error:

Error producing PDF.
! LaTeX Error: File `algorithm.sty' not found.

Type X to quit or to proceed,
or enter new name. (Default extension: sty)

Enter file name:
! Emergency stop.
<read *>

l.255 \usepackage

Looks like we failed to compile the PDF

@mlindsk

This comment has been minimized.

Copy link

commented Aug 17, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

PDF failed to compile for issue #1653 with the following error:

Error producing PDF.
! Undefined control sequence.
l.298 \algrenewcommand

Looks like we failed to compile the PDF

@mlindsk

This comment has been minimized.

Copy link

commented Aug 17, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

@mlindsk

This comment has been minimized.

Copy link

commented Aug 17, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

@mlindsk

This comment has been minimized.

Copy link

commented Aug 17, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

@mlindsk

This comment has been minimized.

Copy link

commented Aug 17, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

@mlindsk

This comment has been minimized.

Copy link

commented Aug 17, 2019

@danielskatz Hi Daniel. It finally worked; a hassle to get the spacing right.

@danielskatz

This comment has been minimized.

Copy link

commented Aug 17, 2019

Thanks - can you now add something about what types of research this enables? And how such research will use it?

@danielskatz

This comment has been minimized.

Copy link

commented Aug 17, 2019

👋 @csoneson - would you be willing to edit this submission?

@mlindsk

This comment has been minimized.

Copy link

commented Aug 17, 2019

Sure. I'll look into this Monday morning (afternoon here in Denmark).

@csoneson

This comment has been minimized.

Copy link

commented Aug 18, 2019

@whedon assign @csoneson as editor

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 18, 2019

OK, the editor is @csoneson

@csoneson

This comment has been minimized.

Copy link

commented Aug 18, 2019

👋mlindsk - I will handle your submission. Do you have suggestions for suitable reviewers (e.g. from the list linked in the first comment above)?

A couple of initial comments, in addition to @danielskatz's above:

  • Please only include the references that you are citing in the .bib file
  • It looks like there are no actual tests in the testthat/ folder - could you add that?
  • Check the capitalization of "Proceedings of the seventeenth conference..."
@mlindsk

This comment has been minimized.

Copy link

commented Aug 18, 2019

@csoneson That is great. I will look through the list and propose someone as reviewer. And I will handle @danielskatz and your comments first thing tomorrow morning.

@mlindsk

This comment has been minimized.

Copy link

commented Aug 18, 2019

Hi,

Would any of you be willing to review the molic package ?

@VivekTodur
@jkanche

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.