Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[PRE REVIEW]: Open-Unmix - A Reference Implementation for Music Source Separation #1659
Comments
whedon
added
the
pre-review
label
Aug 18, 2019
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
What happens now? This submission is currently in a You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Failed to discover a valid open source license. |
whedon
added
the
TeX
label
Aug 18, 2019
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1659 with the following error: /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/lib/whedon.rb:143:in |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 18, 2019
Please merge sigsep/open-unmix-paper-joss#1 and see if that enables the paper to build by entering |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 18, 2019
|
This comment has been minimized.
This comment has been minimized.
faroit
commented
Aug 18, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
faroit
commented
Aug 18, 2019
@danielskatz regarding the use of submodules, please note my questions I asked earlier in JOSS#565. |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 18, 2019
Thanks for pointing that out - please also mention it in the review thread that will be created once there are an editor and reviewers assigned. |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 18, 2019
Also, while we wait for that, you might want to make some fixes in the bib part of the paper - anything in a title or booktitle that should be in Upper Case needs to be protected with {}s, for example Another example is |
This comment has been minimized.
This comment has been minimized.
faroit
commented
Aug 18, 2019
•
sure, will do. Another question: can you please point me to JOSSs pre-print policy? E.g. can I simultaneously submit to arxiv? |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 18, 2019
This is fine, although it's a little unusual - JOSS papers are usually short and focus on the software itself, while authors often write longer papers about the use of the software, for journals or conferences, and those longer papers are the ones that are usually submitted as pre-prints. |
This comment has been minimized.
This comment has been minimized.
faroit
commented
Aug 19, 2019
maybe our contribution is a bit unusual here, indeed. We actually wrote the paper to be significanlty longer, describing the technical details of the model (see arxiv branch) and then shortened it to <2000 words to comply with the JOSS policy. Now, we still want to offer a DOI for the community as quickly as possible, because we expect them to cite this paper very soon with the upcoming deadlines of the major conferences in our field. |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 19, 2019
Ok, thanks |
whedon commentedAug 18, 2019
Submitting author: @faroit (Fabian-Robert Stöter)
Repository: https://github.com/sigsep/open-unmix-paper-joss
Version: v1.0.0
Editor: Pending
Reviewer: Pending
Author instructions
Thanks for submitting your paper to JOSS @faroit. Currently, there isn't an JOSS editor assigned to your paper.
@faroit if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type: