Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update haematologica.csl & medicinal-research-reviews.csl #2832

Merged
merged 8 commits into from Jul 22, 2017

Conversation

@POBrien333
Copy link
Contributor

commented Jul 20, 2017

@csl-bot

This comment has been minimized.

Copy link

commented Jul 20, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

Update medicinal-research-reviews.csl
found a tiny mistake.
@csl-bot

This comment has been minimized.

Copy link

commented Jul 20, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 20, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 20, 2017

😃 Your submission passed all our automated tests.

@adam3smith
Copy link
Member

left a comment

A couple of nits. Thanks!

<macro name="author">
<names variable="author" suffix=". ">
<name sort-separator=" " initialize-with="" name-as-sort-order="all" delimiter=", " delimiter-precedes-last="always"/>
<label form="short" prefix=" (" suffix=")" strip-periods="true"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jul 20, 2017

Member

unless there's a specific example, I'd expect the editor format to be the same as for book chapters, i.e. , editor(s)

<text variable="publisher" suffix=";"/>
</group>
<choose>
<if variable="URL" match="none">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jul 20, 2017

Member

this seems odd? Not date when there is a URL?

<macro name="title">
<choose>
<if type="book patent report thesis" match="any">
<text variable="title"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jul 20, 2017

Member

remove choose which doesn't do anything

<text macro="edition"/>
<text macro="publisher"/>
<group>
<text variable="number-of-pages" prefix=" "/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jul 20, 2017

Member

remove the prefix -- the space is already in the delimiter on line 159

</group>
<text macro="publisher"/>
</group>
<label variable="page" form="short" prefix=" "/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jul 20, 2017

Member

no need for the prefix given delimiters

POBrien333 added some commits Jul 20, 2017

@csl-bot

This comment has been minimized.

Copy link

commented Jul 20, 2017

😃 Your submission passed all our automated tests.

1 similar comment
@csl-bot

This comment has been minimized.

Copy link

commented Jul 20, 2017

😃 Your submission passed all our automated tests.

Update medicinal-research-reviews.csl
also overworked this style (the template style). Found a few samples for chapters thankfully, as it's not in their guidelines.

@POBrien333 POBrien333 changed the title Update haematologica.csl Update haematologica.csl & medicinal-research-reviews.csl Jul 20, 2017

@csl-bot

This comment has been minimized.

Copy link

commented Jul 20, 2017

😟 There are some issues with your submission. Please check the test report for details.

POBrien333 added some commits Jul 20, 2017

@csl-bot

This comment has been minimized.

Copy link

commented Jul 20, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 20, 2017

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit b0a3604 into citation-style-language:master Jul 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

commented Jul 22, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.