New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create plant-genetic-resources-characterization-and-utilization.csl #4256

Merged

adam3smith merged 3 commits into citation-style-language:master from POBrien333:patch-556

Aug 21, 2019

+305 −0

Contributor

POBrien333 commented Aug 19, 2019

via https://forums.zotero.org/discussion/78389/style-request-plant-genetic-resources-characterization-and-utilization


      Create plant-genetic-resources-characterization-and-utilization.csl

via https://forums.zotero.org/discussion/78389/style-request-plant-genetic-resources-characterization-and-utilization#latest

e90cbf0

csl-bot commented Aug 19, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

csl-bot commented Aug 19, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

plant-genetic-resources-characterization-and-utilization.csl (new)

(Hancké et al., 2007; CSL search by example, 2012)
(Mares, 2001; Fenner et al., 2019)

CSL search by example (2012) CSL search by example. Available at http://editor.citationstyles.org/searchByExample/ (accessed 15 December 2012).
Fenner M et al. (2019) A data citation roadmap for scholarly data repositories. Scientific Data 6: 28.
Hancké B, Rhodes M and Thatcher M (eds) (2007) Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press: Oxford and New York.
Mares I (2001) Firms and the welfare state: When, why, and how does social policy matter to employers? In: Hall PA and Soskice D (eds). Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. Oxford University Press: New York, pp. 184–213.

adam3smith requested changes Aug 20, 2019

View changes

Member

adam3smith left a comment

Some nits -- mainly clean-up from the very specific content of the template.

plant-genetic-resources-characterization-and-utilization.csl Outdated

  
              </if>

              <else>

                <choose>

                  <if variable="call-number">

adam3smith Aug 20, 2019

Member

that seems very odd -- I assume inherited? But would remove.

plant-genetic-resources-characterization-and-utilization.csl Outdated

  
              <if type="bill book graphic legal_case legislation motion_picture song" match="any">

                <text variable="title" font-style="italic" text-case="title"/>

              </if>

              <else-if type="report" match="any">

adam3smith Aug 20, 2019

Member

not needed - remove.

plant-genetic-resources-characterization-and-utilization.csl Outdated

  
          </macro>

          <macro name="access-date">

            <choose>

              <if type="webpage post post-weblog">

adam3smith Aug 20, 2019

Member

add match="any"

plant-genetic-resources-characterization-and-utilization.csl Outdated

  
              </else>

            </choose>

          </macro>

          <macro name="extra">

adam3smith Aug 20, 2019

Member

What is this for? Better to remove -- I prefer not to have note/extra in styles.

plant-genetic-resources-characterization-and-utilization.csl Outdated

  
              </if>

            </choose>

          </macro>

          <macro name="un-sales">

adam3smith Aug 20, 2019

Member

this seems like a leftover - remove

plant-genetic-resources-characterization-and-utilization.csl Outdated

  
              <else-if type="bill book chapter graphic legal_case legislation motion_picture paper-conference song" match="any">

                <choose>

                  <if variable="collection-title">

                    <group delimiter=", ">

adam3smith Aug 20, 2019

Member

handle the spaces here more elegantly (e.g. no need for the one before "No." and the one before "Vol." should probably be a group prefix)

plant-genetic-resources-characterization-and-utilization.csl Outdated

  
            </choose>

          </macro>

          <macro name="citation-locator">

            <group>

adam3smith Aug 20, 2019

Member

no need for this -- just delete macro

plant-genetic-resources-characterization-and-utilization.csl Outdated

  
                <text macro="author-short"/>

                <text macro="year-date"/>

              </group>

              <text macro="citation-locator"/>

adam3smith Aug 20, 2019

Member

and then handle the colon before the locator here.

plant-genetic-resources-characterization-and-utilization.csl Outdated

  
                  <date variable="issued">

                    <date-part name="month" prefix=" "/>

                  </date>

                  <text variable="URL" prefix=". Available at " font-style="normal"/>

adam3smith Aug 20, 2019

Member

could we pack this into a macro and handle available at with a term?


      Update plant-genetic-resources-characterization-and-utilization.csl

Thank you for the thorough review. Obviously not an ideal style to base this one on.

42b0c77

csl-bot commented Aug 20, 2019

😟 There are some issues with your submission.

1 test failed

plant-genetic-resources-characterization-and-utilization: must define all macros that are called by <text/> and <key/> elements

expected #has_key?("citation-locator") to return true, got false

Please check the test report for details.


      Update plant-genetic-resources-characterization-and-utilization.csl

514f39b

csl-bot commented Aug 20, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

plant-genetic-resources-characterization-and-utilization.csl (new)

(Hancké et al., 2007; CSL search by example, 2012)
(Mares, 2001; Fenner et al., 2019)

CSL search by example (2012) Citation Style Editor. See http://editor.citationstyles.org/searchByExample/ (accessed 15 December 2012).
Fenner M et al. (2019) A data citation roadmap for scholarly data repositories. Scientific Data 6: 28.
Hancké B, Rhodes M and Thatcher M (eds) (2007) Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press: Oxford and New York.
Mares I (2001) Firms and the welfare state: When, why, and how does social policy matter to employers? In: Hall PA and Soskice D (eds). Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. Oxford University Press: New York, pp. 184–213.

adam3smith merged commit `51c0851` into citation-style-language:master Aug 21, 2019
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

Details

Member

adam3smith commented Aug 21, 2019

Great thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.