Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upExtract PDF #340
+93
−25
Conversation
jrwiebe
and others
added some commits
Feb 1, 2019
ruebot
approved these changes
Aug 12, 2019
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Aug 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
==========================================
- Coverage 74.95% 73.49% -1.46%
==========================================
Files 39 39
Lines 1122 1147 +25
Branches 197 198 +1
==========================================
+ Hits 841 843 +2
- Misses 214 237 +23
Partials 67 67
Continue to review full report at Codecov.
|
ruebot
merged commit 73981a7
into
master
Aug 12, 2019
ruebot
deleted the
extract-pdf
branch
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jrwiebe commentedAug 12, 2019
This PR introduces the new
extractPDFDetailsDF()method and brings in changes to make our use of Tika's MIME type detection more efficient, as well as POM updates to use a shaded version oftika-parsersin order to eliminate a dependency version conflict that has long been troublesome.GitHub issue:
How should this be tested?
Discussion in #302 describes tests run by @ruebot and @jrwiebe – e.g., this.