Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logfixes simpler #7

Merged
merged 2 commits into from Sep 4, 2019

Conversation

@shawnmjones
Copy link

commented Sep 3, 2019

Here I have provided some changes to logfixes that will make it easier for others to consume this module.

Notes:

  • params={'a': 'b', ...} has been replaced by explicitly named parameters for these functions
  • logging has been simplified - it is up to the calling function/module/script to specify the logging level, handlers, etc. - don't try to do their work for them - if such functions are needed, put them in another file in this module (like I did for the OTMT)
  • I tried to update the README as appropriate

@anwala anwala merged commit 5d45e12 into logfixes Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.