Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pnas.csl #4285

Merged
merged 6 commits into from Aug 30, 2019
+76 −56

Conversation

@POBrien333
Copy link
Contributor

commented Aug 29, 2019 •
edited

PNAS completely changed style. Please review. :)
Guidelines lack quite a bit of substance, so it's only really adapted for article-journal and chapter (and book extrapolated from that).
https://forums.zotero.org/discussion/78866/pnas-reference-update
@POBrien333
Update pnas.csl 
PNAS completely changed style: 
https://forums.zotero.org/discussion/78866/pnas-reference-update
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
406a877
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 29, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 29, 2019

😟 There are some issues with your submission.

1 test failed

pnas: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[33, "33:0: ERROR: Did not expect element macro there"], [33, "33:0: ERROR: Element style has extra content: macro"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to return true, got false

Please check the test report for details.
@POBrien333
Update pnas.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
632177a
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 29, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

pnas.csl (modified style)
(1, 2)
(3, 4)
1. B. Hancké, M. Rhodes, M. Thatcher, Eds., “Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy,” Oxford University Press (2007).
2. CSL search by exampleCitation Style Editor (2012) (December 15, 2012).
3. I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?” in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, P. A. Hall, D. Soskice, Eds. (Oxford University Press, 2001), pp. 184–213.
4. M. Fenner, et al., A data citation roadmap for scholarly data repositories. Scientific Data 6, 28 (2019).
 (1, 2)<br/>
 (3, 4)<br/>
 <hr/>
-1. Hancké B, Rhodes M, Thatcher M eds. (2007) <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i> (Oxford University Press, Oxford and New York).<br/>
-2. CSL search by example (2012) <i>Citation Style Editor</i>. Available at: http://editor.citationstyles.org/searchByExample/ [Accessed December 15, 2012].<br/>
-3. Mares I (2001) Firms and the welfare state: When, why, and how does social policy matter to employers? <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, eds Hall PA, Soskice D (Oxford University Press, New York), pp 184–213.<br/>
-4. Fenner M, et al. (2019) A data citation roadmap for scholarly data repositories. <i>Scientific Data</i> 6(1):28.<br/>
+1. B. Hancké, M. Rhodes, M. Thatcher, Eds., “<i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i>,” Oxford University Press (2007).<br/>
+2. CSL search by example<i>Citation Style Editor</i> (2012) (December 15, 2012).<br/>
+3. I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?” in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, P. A. Hall, D. Soskice, Eds. (Oxford University Press, 2001), pp. 184–213.<br/>
+4. M. Fenner, <i>et al.</i>, A data citation roadmap for scholarly data repositories. <i>Scientific Data</i> <b>6</b>, 28 (2019).<br/>
@adam3smith
align book & chapter publishers
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2f13d3b
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 29, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

pnas.csl (modified style)
(1, 2)
(3, 4)
1. B. Hancké, M. Rhodes, M. Thatcher, Eds., “Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy” (Oxford University Press, 2007).
2. CSL search by exampleCitation Style Editor (2012) (December 15, 2012).
3. I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?” in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, P. A. Hall, D. Soskice, Eds. (Oxford University Press, 2001), pp. 184–213.
4. M. Fenner, et al., A data citation roadmap for scholarly data repositories. Scientific Data 6, 28 (2019).
 (1, 2)<br/>
 (3, 4)<br/>
 <hr/>
-1. Hancké B, Rhodes M, Thatcher M eds. (2007) <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i> (Oxford University Press, Oxford and New York).<br/>
-2. CSL search by example (2012) <i>Citation Style Editor</i>. Available at: http://editor.citationstyles.org/searchByExample/ [Accessed December 15, 2012].<br/>
-3. Mares I (2001) Firms and the welfare state: When, why, and how does social policy matter to employers? <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, eds Hall PA, Soskice D (Oxford University Press, New York), pp 184–213.<br/>
-4. Fenner M, et al. (2019) A data citation roadmap for scholarly data repositories. <i>Scientific Data</i> 6(1):28.<br/>
+1. B. Hancké, M. Rhodes, M. Thatcher, Eds., “<i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i>” (Oxford University Press, 2007).<br/>
+2. CSL search by example<i>Citation Style Editor</i> (2012) (December 15, 2012).<br/>
+3. I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?” in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, P. A. Hall, D. Soskice, Eds. (Oxford University Press, 2001), pp. 184–213.<br/>
+4. M. Fenner, <i>et al.</i>, A data citation roadmap for scholarly data repositories. <i>Scientific Data</i> <b>6</b>, 28 (2019).<br/>
@adam3smith
Fix up titles based on articles
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c117d58
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 29, 2019

😟 There are some issues with your submission.

2 tests failed

pnas: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "187:1: FATAL: Premature end of data in tag style line 2"]].empty?` to return true, got false

pnas: must define all macros that are called by <text/> and <key/> elements

expected #has_key?("edition") to return true, got false

Please check the test report for details.
@adam3smith
fix validation
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c4578d6
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 29, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

pnas.csl (modified style)
(1, 2)
(3, 4)
1. B. Hancké, M. Rhodes, M. Thatcher, Eds., Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy (Oxford University Press, 2007).
2. CSL search by exampleCitation Style Editor (2012) (December 15, 2012).
3. I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?” in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, P. A. Hall, D. Soskice, Eds. (Oxford University Press, 2001), pp. 184–213.
4. M. Fenner, et al., A data citation roadmap for scholarly data repositories. Scientific Data 6, 28 (2019).
 (1, 2)<br/>
 (3, 4)<br/>
 <hr/>
-1. Hancké B, Rhodes M, Thatcher M eds. (2007) <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i> (Oxford University Press, Oxford and New York).<br/>
-2. CSL search by example (2012) <i>Citation Style Editor</i>. Available at: http://editor.citationstyles.org/searchByExample/ [Accessed December 15, 2012].<br/>
-3. Mares I (2001) Firms and the welfare state: When, why, and how does social policy matter to employers? <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, eds Hall PA, Soskice D (Oxford University Press, New York), pp 184–213.<br/>
-4. Fenner M, et al. (2019) A data citation roadmap for scholarly data repositories. <i>Scientific Data</i> 6(1):28.<br/>
+1. B. Hancké, M. Rhodes, M. Thatcher, Eds., <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i> (Oxford University Press, 2007).<br/>
+2. CSL search by example<i>Citation Style Editor</i> (2012) (December 15, 2012).<br/>
+3. I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, P. A. Hall, D. Soskice, Eds. (Oxford University Press, 2001), pp. 184–213.<br/>
+4. M. Fenner, <i>et al.</i>, A data citation roadmap for scholarly data repositories. <i>Scientific Data</i> <b>6</b>, 28 (2019).<br/>
@adam3smith
Work better for works without author
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4577608
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 29, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

pnas.csl (modified style)
(1, 2)
(3, 4)
1. B. Hancké, M. Rhodes, M. Thatcher, Eds., Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy (Oxford University Press, 2007).
2. , CSL search by example. Citation Style Editor (2012) (December 15, 2012).
3. I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?” in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, P. A. Hall, D. Soskice, Eds. (Oxford University Press, 2001), pp. 184–213.
4. M. Fenner, et al., A data citation roadmap for scholarly data repositories. Scientific Data 6, 28 (2019).
 (1, 2)<br/>
 (3, 4)<br/>
 <hr/>
-1. Hancké B, Rhodes M, Thatcher M eds. (2007) <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i> (Oxford University Press, Oxford and New York).<br/>
-2. CSL search by example (2012) <i>Citation Style Editor</i>. Available at: http://editor.citationstyles.org/searchByExample/ [Accessed December 15, 2012].<br/>
-3. Mares I (2001) Firms and the welfare state: When, why, and how does social policy matter to employers? <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, eds Hall PA, Soskice D (Oxford University Press, New York), pp 184–213.<br/>
-4. Fenner M, et al. (2019) A data citation roadmap for scholarly data repositories. <i>Scientific Data</i> 6(1):28.<br/>
+1. B. Hancké, M. Rhodes, M. Thatcher, Eds., <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i> (Oxford University Press, 2007).<br/>
+2. , CSL search by example. <i>Citation Style Editor</i> (2012) (December 15, 2012).<br/>
+3. I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, P. A. Hall, D. Soskice, Eds. (Oxford University Press, 2001), pp. 184–213.<br/>
+4. M. Fenner, <i>et al.</i>, A data citation roadmap for scholarly data repositories. <i>Scientific Data</i> <b>6</b>, 28 (2019).<br/>
@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Aug 30, 2019

Thanks for looking over it.
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 30, 2019

PNAS completely changed style.

No template used?
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 30, 2019

No template used?

Pretty sure this is based on the old style which didn't have a template in there.

@rmzelle rmzelle merged commit d1bb632 into citation-style-language:master Aug 30, 2019
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 30, 2019 •
edited

Yeah, looks like it. Thanks both!

(by the same person who posted to the Zotero forums: https://twitter.com/SamPassmore_/status/1166989872944623623)
@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Aug 30, 2019

Template was just the old pnas.csl. :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@POBrien333 @csl-bot @rmzelle @adam3smith
You can’t perform that action at this time.