New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for haven 2.0.0 compatibility #188

Closed
leeper opened this Issue Aug 29, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@leeper
Owner

leeper commented Aug 29, 2018

NEWS: https://github.com/tidyverse/haven/blob/master/NEWS.md#haven-1129000

== CHECK RESULTS ========================================

*   checking examples ... ERROR
    ```
    ...
    List of 5
     $ label    : chr "1978 Automobile Data"
     $ notes    : chr [1:2] "from Consumer Reports with permission" "1"
     $ names    : chr [1:12] "make" "price" "mpg" "rep78" ...
     $ row.names: int [1:74] 1 2 3 4 5 6 7 8 9 10 ...
     $ class    : chr "data.frame"
    > str(g)
    'data.frame':       74 obs. of  12 variables:
     $ make        : chr  "AMC Concord" "AMC Pacer" "AMC Spirit"
"Buick Century" ...
     $ price       : num  4099 4749 3799 4816 7827 ...
     $ mpg         : num  22 17 22 20 15 18 26 20 16 19 ...
     $ rep78       : num  3 3 NA 3 4 3 NA 3 3 3 ...
     $ headroom    : num  2.5 3 3 4.5 4 4 3 2 3.5 3.5 ...
     $ trunk       : num  11 11 12 16 20 21 10 16 17 13 ...
     $ weight      : num  2930 3350 2640 3250 4080 3670 2230 3280 3880 3400 ...
     $ length      : num  186 173 168 196 222 218 170 200 207 200 ...
     $ turn        : num  40 40 35 40 43 43 34 42 43 42 ...
     $ displacement: num  121 258 121 196 350 231 304 196 231 231 ...
     $ gear_ratio  : num  3.58 2.53 3.08 2.93 2.41 ...
     $ foreign     :Error: `x` and `labels` must be same type
    Execution halted
    ```

@leeper leeper added the bug label Aug 29, 2018

leeper added a commit that referenced this issue Aug 29, 2018

@leeper leeper closed this in 7955dce Nov 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment