/rio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx bmp import typo. Add import notes for ledger package. #190

Merged
merged 4 commits into from Nov 25, 2018
+35 −6

Conversation

Reviewers

@leeper leeper

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
3 participants
@trevorld @codecov-io @leeper
@trevorld
Contributor

trevorld commented Aug 30, 2018

As you requested in #173 changes made to extensions.R.

Please ensure the following before submitting a PR:

  • if suggesting code changes or improvements, open an issue first
  • for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
  • add code or new test files to /tests for any new functionality or bug fix
  • make sure R CMD check runs without error before submitting the PR

@trevorld trevorld referenced this pull request Aug 30, 2018

Closed

Write rio import wrappers around register function #7

@leeper leeper added the enhancement label Aug 30, 2018

@leeper

leeper reviewed Aug 30, 2018
View changes

Show resolved Hide resolved tests/testthat/test_format_external_packages.R Outdated
Show resolved Hide resolved tests/testthat/test_format_external_packages.R Outdated
@trevorld
Just a simple expect_error check
Loading status checks…
15263ab
@codecov-io

This comment has been minimized.

Sign in to view

codecov-io commented Aug 30, 2018

Codecov Report

Merging #190 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #190     +/-   ##
=========================================
+ Coverage   81.89%   81.99%   +0.1%     
=========================================
  Files          18       18             
  Lines         856      861      +5     
=========================================
+ Hits          701      706      +5     
  Misses        155      155
Impacted Files Coverage Δ
R/extensions.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11eeb02...15263ab. Read the comment docs.
@trevorld

This comment has been minimized.

Sign in to view
Contributor

trevorld commented Nov 13, 2018

I made the changes you requested several months ago. Anything else you wanted me to do?

@leeper leeper merged commit 5fb23ae into leeper:master Nov 25, 2018
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment