Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[PRE REVIEW]: GaitPy: An Open-Source Python Package for Gait Analysis Using an Accelerometer on the Lower Back #1713
Comments
whedon
added
the
pre-review
label
Sep 6, 2019
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
What happens now? This submission is currently in a You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here. |
This comment has been minimized.
This comment has been minimized.
|
whedon
added
HTML
Python
TeX
labels
Sep 6, 2019
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1713 with the following error: /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in |
This comment has been minimized.
This comment has been minimized.
Second, it's not immediately clear to me that your submission is currently up to standard for JOSS yet I'm afraid. In particular the fact that this is a written for Python 2.7 suggests to me that this package is close to deprecated and not 'designed for maintainable extension'. Also, there don't currently appear to be any automated/unit tests which will be a problem during review. |
arfon
added
the
paused
label
Sep 6, 2019
This comment has been minimized.
This comment has been minimized.
Matt-pfz
commented
Sep 6, 2019
Thank you for your edits and feedback. I will work to address these problems with the submission and update you when completed. |
This comment has been minimized.
This comment has been minimized.
Matt-pfz
commented
Sep 17, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Matt-pfz
commented
Sep 17, 2019
@arfon, I have worked to address the issues you brought up. The package is compatible with Python 3.6 and offers a demo in order to test the functionality. Any feedback is appreciated. I look forward to going through the process of submission. |
This comment has been minimized.
This comment has been minimized.
Matt-pfz
commented
Sep 17, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kthyng
commented
Sep 17, 2019
Hi @trallard! I see you work in biomechanics. Could you edit this submission? |
arfon
removed
the
paused
label
Sep 17, 2019
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Sep 25, 2019
|
whedon commentedSep 6, 2019
Submitting author: @mdc007 (Matthew Czech)
Repository: https://github.com/matt002/GaitPy
Version: v1.0
Editor: Pending
Reviewer: Pending
Author instructions
Thanks for submitting your paper to JOSS @mdc007. Currently, there isn't an JOSS editor assigned to your paper.
@mdc007 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type: