Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: GaitPy: An Open-Source Python Package for Gait Analysis Using an Accelerometer on the Lower Back #1713

Open
whedon opened this issue Sep 6, 2019 · 14 comments

Comments

@whedon
Copy link
Collaborator

commented Sep 6, 2019

Submitting author: @mdc007 (Matthew Czech)
Repository: https://github.com/matt002/GaitPy
Version: v1.0
Editor: Pending
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @mdc007. Currently, there isn't an JOSS editor assigned to your paper.

@mdc007 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label Sep 6, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 6, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 6, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 6, 2019

PDF failed to compile for issue #1713 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse': (tmp/1713/paper/paper.md): found character that cannot start any token while scanning for the next token at line 4 column 4 (Psych::SyntaxError) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse_stream'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:325:in parse' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:252:in load'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:473:in block in load_file' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in open'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in load_file' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon.rb:115:in load_yaml'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon.rb:85:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon/processor.rb:36:in new'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon/processor.rb:36:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:55:in prepare'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:116:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

@arfon

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

👋 @mdc007, many thanks for your submission to JOSS. Firstly, this pull request should fix your paper compilation: matt002/GaitPy#1

Second, it's not immediately clear to me that your submission is currently up to standard for JOSS yet I'm afraid. In particular the fact that this is a written for Python 2.7 suggests to me that this package is close to deprecated and not 'designed for maintainable extension'.

Also, there don't currently appear to be any automated/unit tests which will be a problem during review.

@arfon arfon added the paused label Sep 6, 2019

@Matt-pfz

This comment has been minimized.

Copy link

commented Sep 6, 2019

Thank you for your edits and feedback. I will work to address these problems with the submission and update you when completed.

@Matt-pfz

This comment has been minimized.

Copy link

commented Sep 17, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 17, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 17, 2019

@Matt-pfz

This comment has been minimized.

Copy link

commented Sep 17, 2019

@arfon, I have worked to address the issues you brought up. The package is compatible with Python 3.6 and offers a demo in order to test the functionality. Any feedback is appreciated. I look forward to going through the process of submission.

@Matt-pfz

This comment has been minimized.

Copy link

commented Sep 17, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 17, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 17, 2019

@kthyng

This comment has been minimized.

Copy link

commented Sep 17, 2019

Hi @trallard! I see you work in biomechanics. Could you edit this submission?

@arfon arfon removed the paused label Sep 17, 2019

@danielskatz

This comment has been minimized.

Copy link

commented Sep 25, 2019

👋 @meg-simula - would you be willing to edit this submission?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.