Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[PRE REVIEW]: PyLUR: A land use regression wizard for ArcGIS Pro #1753
Comments
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
What happens now? This submission is currently in a You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1753 with the following error: /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/lib/whedon.rb:135:in |
This comment has been minimized.
This comment has been minimized.
kthyng
commented
Sep 21, 2019
Hi @anmolter, I have some concerns about your submission that need to be addressed before we can move forward on your submission. As it stands, it is failing on the submission requirement of
since to look at the files, one needs to download a big zip file and unzip. Therefore, the packaging of your submission needs improvement before we can review it. Other important improvements include documentation and tests for your code. |
This comment has been minimized.
This comment has been minimized.
anmolter
commented
Sep 23, 2019
I have removed the zip files and replaced them with browsable folders in the repository. I have changed the README.md, so it now recommends to clone or download the repository and it shows that the documentation and tutorial is in the manual. |
This comment has been minimized.
This comment has been minimized.
anmolter
commented
Sep 23, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1753 with the following error: Could not find bibliography file: PyLUR_paper.bib |
This comment has been minimized.
This comment has been minimized.
anmolter
commented
Sep 23, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1753 with the following error: Error reading bibliography ./paper.bib (line 14, column 13): |
This comment has been minimized.
This comment has been minimized.
anmolter
commented
Sep 23, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Sep 23, 2019
•
I think we can now start the process of editing and review, but I expect there will be a fairly large number of issues brought up by the reviewers, as this code doesn't appear to be as modular as I would expect, and there are machine dependencies, including the fact that the instructions to read the manual likely won't work on a non-PC. |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Sep 23, 2019
|
This comment has been minimized.
This comment has been minimized.
ooo
bot
commented
Sep 23, 2019
Letting you know, |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Sep 29, 2019
|
whedon commentedSep 21, 2019
Submitting author: @anmolter (Anna Mölter)
Repository: https://github.com/anmolter/PyLUR
Version: v2.2.4 or higher
Editor: Pending
Reviewer: Pending
Author instructions
Thanks for submitting your paper to JOSS @anmolter. Currently, there isn't an JOSS editor assigned to your paper.
@anmolter if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type: