Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: PyLUR: A land use regression wizard for ArcGIS Pro #1753

Open
whedon opened this issue Sep 21, 2019 · 18 comments

Comments

@whedon
Copy link
Collaborator

commented Sep 21, 2019

Submitting author: @anmolter (Anna Mölter)
Repository: https://github.com/anmolter/PyLUR
Version: v2.2.4 or higher
Editor: Pending
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @anmolter. Currently, there isn't an JOSS editor assigned to your paper.

@anmolter if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon whedon added the pre-review label Sep 21, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 21, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 21, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon whedon added the TeX label Sep 21, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 21, 2019

PDF failed to compile for issue #1753 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/lib/whedon.rb:135:in check_fields': Paper YAML header is missing expected fields: affiliations (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/lib/whedon.rb:87:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/lib/whedon/processor.rb:36:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/lib/whedon/processor.rb:36:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/bin/whedon:55:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@kthyng

This comment has been minimized.

Copy link

commented Sep 21, 2019

Hi @anmolter, I have some concerns about your submission that need to be addressed before we can move forward on your submission. As it stands, it is failing on the submission requirement of

Be stored in a repository that is browsable online without registration

since to look at the files, one needs to download a big zip file and unzip. Therefore, the packaging of your submission needs improvement before we can review it.

Other important improvements include documentation and tests for your code.

@anmolter

This comment has been minimized.

Copy link

commented Sep 23, 2019

I have removed the zip files and replaced them with browsable folders in the repository. I have changed the README.md, so it now recommends to clone or download the repository and it shows that the documentation and tutorial is in the manual.
I have also fixed the typo in paper.md, so it is now 'affiliations' instead of 'affiliation'.

@anmolter

This comment has been minimized.

Copy link

commented Sep 23, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 23, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 23, 2019

PDF failed to compile for issue #1753 with the following error:

Could not find bibliography file: PyLUR_paper.bib
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

@anmolter

This comment has been minimized.

Copy link

commented Sep 23, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 23, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 23, 2019

PDF failed to compile for issue #1753 with the following error:

Error reading bibliography ./paper.bib (line 14, column 13):
unexpected "H"
expecting space or ","
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

@anmolter

This comment has been minimized.

Copy link

commented Sep 23, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 23, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 23, 2019

@danielskatz

This comment has been minimized.

Copy link

commented Sep 23, 2019

I think we can now start the process of editing and review, but I expect there will be a fairly large number of issues brought up by the reviewers, as this code doesn't appear to be as modular as I would expect, and there are machine dependencies, including the fact that the instructions to read the manual likely won't work on a non-PC.

@danielskatz

This comment has been minimized.

Copy link

commented Sep 23, 2019

👋 @leouieda - I know you have a fair number of papers now, but would you also be willing to take on this one?

@ooo

This comment has been minimized.

Copy link

commented Sep 23, 2019

👋 Hey @danielskatz...

Letting you know, @leouieda is currently OOO until Sunday, September 29th 2019. ❤️

@danielskatz

This comment has been minimized.

Copy link

commented Sep 29, 2019

👋 @leouieda - I know you have a fair number of papers now, but would you also be willing to take on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.